Fix random_activation_in_scope panic and simplify implementation#109
Merged
HyperCodec merged 2 commits intodevfrom Feb 20, 2026
Merged
Fix random_activation_in_scope panic and simplify implementation#109HyperCodec merged 2 commits intodevfrom
random_activation_in_scope panic and simplify implementation#109HyperCodec merged 2 commits intodevfrom
Conversation
Co-authored-by: HyperCodec <72839119+HyperCodec@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update version 1.0.0 with massive rewrite
Fix Feb 20, 2026
random_activation_in_scope panic and simplify implementation
HyperCodec
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivationRegistry::random_activation_in_scopewould panic viausizeunderflow when the registry had 0 entries (len() - 1wraps), and produce an empty range panic with exactly 1 entry. The cyclic-iterator approach was also unnecessarily convoluted.Changes
src/activation.rs: Replace the cyclic-iterator loop with a direct call toactivations_in_scope, assert non-empty with a descriptive message, then index randomly:# Panicsdoc section documenting the empty-scope assertion.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.