Open
Conversation
Contributor
|
can you split up this PR so it just includes the fix and the changes to the readme and make separate PRs for the other changes please. PR's need to be atomic and focused so they are easy to review. |
43e63ce to
1d10a24
Compare
Fixes user modes in channel, channel modes, and channel creation time parsing on joining for IRCDs that use valid syntax of not putting a space between the : and the last argument of the result/command
1d10a24 to
9238040
Compare
Contributor
Author
|
@hydra cleaned up unrelated license changes, I'll do the whole bulk license change as one PR. Note about .168 was omitted from the update it was in, FYI. Might be a good idea running this through a formatter at some point for consistency once it's VS2012+. You'll have to let me know if you have any preferred standards for that. |
Contributor
Author
|
@hydra Howdy! Long time no chat and all that.... Was hoping you had a chance to glance by this at some point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes user modes in channel, topic timestamp parsing, channel modes, and channel creation time parsing on joining for IRCDs that use valid syntax of not putting a space between the : and the last argument of the result/command
UI is properly updating with status (op/voice) channel mode changes now on these networks.
Test run on InspIRCD-3 server that exhibits this behavior:
[22:47] *** now talking in #test908
[22:47] *** channel #test908 mode is +CFTfjntx 5:60 30:5 5:1 :10:5
[22:47] *** channel created at Mon Oct 09 22:47:25 2023
[22:47] *** test12345 changed topic to test
[22:48] *** test32489 (test32489!test@Snoonet-gua.fjv.uensmt.IP) joined
[22:48] *** test12345 sets channel #test908 mode +o test32489
[22:48] *** now talking in #test908
[22:48] *** topic is test
[22:48] *** set by test12345!test@Snoonet-gua.fjv.uensmt.IP on Mon Oct 09 22:47:30 2023
[22:48] *** channel #test908 mode is +CFTfjntx 5:60 30:5 5:1 :10:5
[22:48] *** channel created at Mon Oct 09 22:47:25 2023
This can close #17