Fix the Inconsistency in cf files command#10
Open
SrinivasChilveri wants to merge 1 commit intoHuaweiTech:hw-issue-12from
Open
Fix the Inconsistency in cf files command#10SrinivasChilveri wants to merge 1 commit intoHuaweiTech:hw-issue-12from
SrinivasChilveri wants to merge 1 commit intoHuaweiTech:hw-issue-12from
Conversation
Before Fix: If cf user does 'cf files my-app' or 'cf files my-app path' then its success but path is niehter optional not required After Fix:If cf user does 'cf files my-app path' then it will succ but 'cf files my-app' will fail so path is now reqired parameter http://rnd-github.huawei.com/paas/cli/issues/12#issuecomment-5478
|
@SrinivasChilveri As we discussed, this PR and issue should be kept open and following cf-cli's plan on V7.0.0. |
Member
Author
|
@liuhewei I have implemented PATH as required parameter.we have not received any info from pivotal to implement as required or optional parameter, so can i do one more PR with PATH as optional parameter? So we will be ready with two options what ever they want we can do PR for that. whats your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Fix: If cf user does
'cf files my-app' or 'cf files my-app path'
then its success but path is niehter optional not required
After Fix:If cf user does
'cf files my-app path'
then it will succ but 'cf files my-app' will fail
so path is now reqired parameter
http://rnd-github.huawei.com/paas/cli/issues/12#issuecomment-5478