Open
Conversation
added 2 commits
April 21, 2016 12:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello: zeronet is greate and I'd like to contribute some new features to ZeroBlog, but zeroblog coffeescript mix space and tabs ,makes it difficult to hack, so I did a quick fix , makes 99% coffeelint warning quiet
first commit is replace all tab to 2 spaces
second commit fix left coffeelint warning , such as
longer than 80
Unnecessary fat arrow
trailing whitespace
trailing semicolon
I've compare js result before and after, only SQL has space and newline differences.
There is only 1 warning left with coffeelint
getObject(elem) => Unnecessary fat arrow but replace it with ->
generated js lacks a call to
this.getObject = bind(this.getObject, this);
so I think this may be a miss warning and left it as it is