Skip to content

Don't round camera position on sync #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xastor wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Don't round camera position on sync #1243

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b56cac8
Round camera position
xastor Nov 4, 2024
3a240d8
Gate behind a define
xastor Nov 10, 2024
15f393b
Refactor to a property
xastor Nov 11, 2024
fe22cde
Simplify the code
xastor Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions h2d/Camera.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ class Camera {
**/
public var followRotation : Bool = false;

/**
Round the camera position?
Setting to false allows the camera to have a sub-pixel accurate position.
**/
public var enableCameraRounding : Bool = true;

var posChanged : Bool;

var viewX : Float;
Expand Down Expand Up @@ -224,8 +230,12 @@ class Camera {
matC = scaleY * -sr;
matD = scaleY * cr;
}
absX = Math.round(-(x * matA + y * matC) + (scene.width * anchorX * viewW) + scene.width * viewX);
absY = Math.round(-(x * matB + y * matD) + (scene.height * anchorY * viewH) + scene.height * viewY);
absX = -(x * matA + y * matC) + (scene.width * anchorX * viewW) + scene.width * viewX;
absY = -(x * matB + y * matD) + (scene.height * anchorY * viewH) + scene.height * viewY;
if (this.enableCameraRounding) {
absX = Math.round(absX);
absY = Math.round(absY);
}
invDet = 1 / (matA * matD - matB * matC);
posChanged = false;
}
Expand Down