Skip to content

Fix release tag pointing to wrong commit when master advances during build#128

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-release-tag-position
Draft

Fix release tag pointing to wrong commit when master advances during build#128
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-release-tag-position

Conversation

Copy link
Contributor

Copilot AI commented Mar 11, 2026

gh release create without --target defaults to the repository's default branch HEAD. Since the three-platform build matrix can take several minutes, any commit pushed to master during that window causes the release tag to land on a different commit than the one actually built and uploaded.

Change

  • Add --target "${{ github.event.pull_request.merge_commit_sha }}" to gh release create in release.yml
gh release create "$TAG" \
  --title "Release $VERSION" \
  --generate-notes \
  --target "${{ github.event.pull_request.merge_commit_sha }}" \
  "${files[@]}"

All build jobs already checkout merge_commit_sha explicitly; this aligns the tag to that same commit so the tag, source, and artifacts are consistent.

Original prompt

This section details on the original issue you should resolve

<issue_title>release tag の位置と artifact の不一致</issue_title>
<issue_description>release branchでworkflowが実行されるけど、ビルド中にmasterが更新されると、tagは最新のmasterについてしまっている。一方 release branch でタグを打つと、squash mergeしたときにmaster上にタグがいないことになってしまう。トリガーを見直す必要がありそう?</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: HayatoYagi <26685974+HayatoYagi@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix release tag position and artifact mismatch Fix release tag pointing to wrong commit when master advances during build Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release tag の位置と artifact の不一致

2 participants