chore: bindings for max_total_wal_size and flush()#6
Merged
Conversation
luislhl
changed the title
luislhl
force-pushed
the
chore/max_total_wal_size_option
branch
2 times, most recently
from
26479f0 to
5c20436
Compare
luislhl
force-pushed
the
fix/ci-cd-macos
branch
from
75fceb3 to
eb556dd
Compare
msbrogli
approved these changes
Feb 5, 2026
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
jansegre
approved these changes
Feb 5, 2026
…parently behaves differently in different environments
luislhl
force-pushed
the
chore/max_total_wal_size_option
branch
from
5c20436 to
0556ac6
Compare
… existing environments. See astral-sh/uv#17757
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
See HathorNetwork/hathor-core#1518
Acceptance Criteria
max_total_wal_size: https://github.com/facebook/rocksdb/blob/v6.11.4/include/rocksdb/options.h#L467Flush()method, specifically the one that supports multiple column-families: https://github.com/facebook/rocksdb/blob/v6.11.4/include/rocksdb/db.h#L1233