Skip to content

Comments

github: Capture Octokit::ClientError#867

Open
kostyanf14 wants to merge 2 commits intoHCK-CI:masterfrom
kostyanf14:RHELMISC-26373
Open

github: Capture Octokit::ClientError#867
kostyanf14 wants to merge 2 commits intoHCK-CI:masterfrom
kostyanf14:RHELMISC-26373

Conversation

@kostyanf14
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @kostyanf14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the error handling mechanism for GitHub API interactions by introducing a dedicated retry wrapper. This change centralizes the logic for retrying failed API calls due to connection issues or server errors, including new handling for Octokit::ClientError. The refactoring improves the maintainability and robustness of the GitHub integration by ensuring consistent and configurable retry behavior across different API operations.

Highlights

  • Centralized Retry Logic: Extracted common retry logic for GitHub API calls into a new private helper method _gh_retry_wrapper, promoting code reuse and maintainability.
  • Enhanced Error Handling: Added Octokit::ClientError to the list of exceptions caught and retried, improving robustness against various client-side API issues.
  • Flexible Retry Behavior: Introduced a raise_on_failure parameter to the new retry wrapper, allowing callers to specify whether to raise an error or continue execution after retry attempts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • lib/auxiliary/github.rb
    • Introduced a new private method _gh_retry_wrapper to encapsulate retry logic for GitHub API calls.
    • Modified create_status to utilize the new _gh_retry_wrapper for its API call, with raise_on_failure set to false.
    • Modified _find_pr to utilize the new _gh_retry_wrapper for its API call.
    • Expanded the error handling in _gh_retry_wrapper to include Octokit::ClientError in addition to existing Faraday and Octokit::ServerError exceptions.
    • Updated the retry logging message to be more generic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a good refactoring by centralizing the GitHub API retry logic into a _gh_retry_wrapper method, which also adds handling for Octokit::ClientError. This improves code reuse and robustness. I have a couple of suggestions to further enhance the new wrapper method: one to simplify the retry logic and another to improve logging detail for better debuggability.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors GitHub API retry handling in AutoHCK::Github to centralize retry logic and expand the set of Octokit exceptions that are retried/handled (notably adding Octokit::ClientError).

Changes:

  • Extracted common retry behavior into a new _gh_retry_wrapper helper.
  • Updated create_status to use the retry wrapper instead of inline retry logic.
  • Updated _find_pr to use the retry wrapper and expanded rescued exceptions to include Octokit::ClientError.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Octokit::ClientError occurs when HTTP request returns
code 429 - This endpoint is temporarily being throttled

We definitly can retry it

Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants