github: Capture Octokit::ClientError#867
Conversation
Summary of ChangesHello @kostyanf14, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the error handling mechanism for GitHub API interactions by introducing a dedicated retry wrapper. This change centralizes the logic for retrying failed API calls due to connection issues or server errors, including new handling for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a good refactoring by centralizing the GitHub API retry logic into a _gh_retry_wrapper method, which also adds handling for Octokit::ClientError. This improves code reuse and robustness. I have a couple of suggestions to further enhance the new wrapper method: one to simplify the retry logic and another to improve logging detail for better debuggability.
There was a problem hiding this comment.
Pull request overview
This PR refactors GitHub API retry handling in AutoHCK::Github to centralize retry logic and expand the set of Octokit exceptions that are retried/handled (notably adding Octokit::ClientError).
Changes:
- Extracted common retry behavior into a new
_gh_retry_wrapperhelper. - Updated
create_statusto use the retry wrapper instead of inline retry logic. - Updated
_find_prto use the retry wrapper and expanded rescued exceptions to includeOctokit::ClientError.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
Octokit::ClientError occurs when HTTP request returns code 429 - This endpoint is temporarily being throttled We definitly can retry it Signed-off-by: Kostiantyn Kostiuk <kkostiuk@redhat.com>
3f000ba to
23a69fd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.