feat: Add swift wasm CI targets to DataLoader#26
feat: Add swift wasm CI targets to DataLoader#26NeedleInAJayStack merged 4 commits intoGraphQLSwift:mainfrom
Conversation
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.8 | |||
| // swift-tools-version:5.10.0 | |||
There was a problem hiding this comment.
Note, this might be a breaking change for some users of this repository, depending on what swift version they are using. It shouldn't be very hard for anyone to move from Swift 5.8 to Swift 5.10, though.
|
The error for swift 5.8 should pass now that the ci change is merged.
|
35fb67c to
ea25a54
Compare
…or the latest swift-nio dependency.
ea25a54 to
ed8b795
Compare
| [](https://tldrlegal.com/license/mit-license) | ||
| [](https://swiftpackageindex.com/GraphQLSwift/DataLoader) | ||
| [](https://swiftpackageindex.com/GraphQLSwift/DataLoader) | ||
| [](https://github.com/GraphQLSwift/DataLoader/actions/workflows/wasm.yml) |
There was a problem hiding this comment.
This is a somewhat theoretical change. Not sure on the best way to test this until it is merged.
|
@NeedleInAJayStack I've rebased this on the latest main. The lint error appears to be on files already merged in main, as those files aren't modified in this PR. Please let me know if you would like me to resolve those in this PR, or in a separate one. |
|
Awesome!
I'm okay with resolving those in this MR. |
|
@NeedleInAJayStack Lint has been addressed now. |
Change summary
Added swift wasm as a CI target, to help prevent future breakages to swift wasm builds in DataLoader
Details
Notes
PR Dependencies
The following PR's must be merged before this PR can be merged:
Testing done
Verified new github workflow builds, once required upstream dependencies are patched in swift-nio
See https://github.com/PassiveLogic/DataLoader/actions/runs/15833601501/job/44631947127?pr=1
Latest test results as of 2026 here:
PassiveLogic#2
Note that there are some lint errors from files not modified in this branch. Likely those lint errors are already in the latest
main.Remaining work