Skip to content

Add some RISC-V support#2001

Open
mmoll wants to merge 2 commits intoGoogleContainerTools:mainfrom
mmoll:rv64
Open

Add some RISC-V support#2001
mmoll wants to merge 2 commits intoGoogleContainerTools:mainfrom
mmoll:rv64

Conversation

@mmoll
Copy link

@mmoll mmoll commented Feb 14, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mmoll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the project's compatibility by integrating RISC-V 64-bit architecture support into its Debian 13 distroless images. The changes involve updating core configuration files to recognize and utilize riscv64, ensuring that the build system and documentation accurately reflect this new platform. This enhancement broadens the range of environments where these distroless images can be deployed.

Highlights

  • RISC-V 64-bit Architecture Support: Introduced support for the riscv64 architecture across various Debian 13-based distroless images, including static, base, base-nossl, and cc.
  • Configuration Updates: Updated configuration files (base/config.bzl, cc/config.bzl, distro.bzl, static/config.bzl) to include riscv64 in the lists of supported architectures for Debian 13.
  • BusyBox Integration: Added a specific http_archive entry for the busybox_riscv64 binary and included it in the module's direct dependencies.
  • Documentation and Aliases: The README.md was updated to reflect the new riscv64 architecture suffixes, and private/util/deb.bzl was modified to include riscv64 in the architecture aliases.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • README.md
    • Updated the architecture suffixes table to include riscv64 for static-debian13, base-debian13, base-nossl-debian13, and cc-debian13 images.
  • base/config.bzl
    • Added riscv64 to the list of supported architectures for debian13.
  • cc/config.bzl
    • Added riscv64 to the list of supported architectures for debian13.
  • distro.bzl
    • Included riscv64 in the global ALL_ARCHITECTURES list.
  • private/extensions/busybox.bzl
    • Added an http_archive definition for busybox_riscv64, including its URL and SHA256 hash.
    • Included busybox_riscv64 in the root_module_direct_deps list.
  • private/util/deb.bzl
    • Added riscv64 to the ARCH_ALIAS dictionary.
  • static/config.bzl
    • Added riscv64 to the list of supported architectures for debian13.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the RISC-V (riscv64) architecture across various components. The changes are generally good, but I've found a critical typo in one of the configuration files that could lead to build failures. I've also pointed out a couple of minor formatting and style issues that should be addressed for consistency.

@loosebazooka
Copy link
Member

Just dropping this in here. I'm on vacation next week Feb 15-20, so likely won't get to this till the week of the 23rd.

@mmoll mmoll force-pushed the rv64 branch 5 times, most recently from f7600ac to 86aef42 Compare February 15, 2026 01:15
@mmoll mmoll marked this pull request as ready for review February 15, 2026 15:12
@mmoll
Copy link
Author

mmoll commented Feb 15, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the RISC-V (riscv64) architecture to various distroless images, primarily for Debian 13. The changes span across configuration files, build scripts, and documentation to include riscv64 as a supported architecture. My review focuses on ensuring consistency and correctness of these additions. I've found a couple of minor issues: one in the documentation (README.md) which is missing the riscv64 architecture for Java images, and another in a comment in private/extensions/busybox.bzl which has an incorrect URL structure. Overall, the changes look good and are well-contained.

@mmoll mmoll mentioned this pull request Feb 15, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants