Conversation
Fixes Gankra#13 ``` sptr on add-license [+] ❯ cargo package --allow-dirty --no-verify Packaging sptr v0.3.2 (/home/michel/src/github/Gankra/sptr) sptr on add-license [+] ❯ tar tf target/package/sptr-0.3.2.crate sptr-0.3.2/.github/workflows/rust.yml sptr-0.3.2/.gitignore sptr-0.3.2/Cargo.toml sptr-0.3.2/Cargo.toml.orig sptr-0.3.2/LICENSE-APACHE sptr-0.3.2/LICENSE-MIT sptr-0.3.2/README.md sptr-0.3.2/src/func.rs sptr-0.3.2/src/int.rs sptr-0.3.2/src/lib.rs ``` Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org>
jrvanwhy
pushed a commit
to jrvanwhy/libtock-rs
that referenced
this pull request
Aug 22, 2023
The semantics of int-to-pointer casts under strict provenance has changed. Ideally, we would update our `From<usize> for Register` implementation to use the `sptr` crate, but `sptr` does not currently have a suitable license. There is a [PR](Gankra/sptr#14) to change that, but it hasn't gotten a response in 7 months, so I don't think we can use it. Instead, this copies the implementation of `core::ptr::invalid`. This also bumps our `thiserror` dependency, which forces Cargo to pick a newer version of `proc-macro2` that is compatible with recently nightly toolchains.
jrvanwhy
pushed a commit
to jrvanwhy/libtock-rs
that referenced
this pull request
Aug 22, 2023
The semantics of int-to-pointer casts under strict provenance has changed. Ideally, we would update our `From<usize> for Register` implementation to use the `sptr` crate, but `sptr` does not currently have a suitable license. There is a [PR](Gankra/sptr#14) to change that, but it hasn't gotten a response in 7 months, so I don't think we can use it. Instead, this copies the implementation of `core::ptr::invalid`. This also bumps our `thiserror` dependency, which forces Cargo to pick a newer version of `proc-macro2` that is compatible with recently nightly toolchains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
Signed-off-by: Michel Alexandre Salim salimma@fedoraproject.org