Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the PlayerFinder mod to version 1.0.3 with support for Minecraft 1.21.10, updating dependencies and fixing compatibility issues.
- Updated Minecraft version from 1.21 to 1.21.10
- Updated Fabric API, Yarn mappings, and Fabric Loader versions
- Fixed API method calls for world registry key retrieval to use
getEntityWorld()instead of deprecatedgetWorld()
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/resources/fabric.mod.json | Updated Minecraft version to 1.21.10 and Fabric API minimum version to 0.138.4 |
| src/main/java/me/imgalvin/playerfinder/PlayerFinder.java | Updated method calls from getWorld() to getEntityWorld() for compatibility with newer Minecraft API |
| gradle.properties | Updated build properties including Minecraft version (1.21.10), Yarn mappings, Fabric Loader (0.18.4), Fabric API (0.138.4), and mod version (1.0.3+1.21.10) |
| README.md | Added version compatibility badge, updated documentation with version-specific jar information, and added changelog entries for versions 1.0.2 and 1.0.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | 1.0.0 | 1.21 - 1.21.1 | 1.0.0+1.21 | | ||
| [](https://modrinth.com/mod/playerfinder) | ||
|
|
||
| AutoTorcher is available for Minecraft versions 1.20 and above! |
There was a problem hiding this comment.
The text references "AutoTorcher" but this appears to be the wrong mod name. Based on the repository context, this should reference "PlayerFinder" instead.
| AutoTorcher is available for Minecraft versions 1.20 and above! | |
| PlayerFinder is available for Minecraft versions 1.20 and above! |
| ## 1.0.3 (1.22.10) | ||
| * For 1.22.10 compatibility |
There was a problem hiding this comment.
The version in the changelog header shows "1.22.10" but should be "1.21.10" to match the actual Minecraft version being released (as shown in gradle.properties and fabric.mod.json).
| ## 1.0.3 (1.22.10) | |
| * For 1.22.10 compatibility | |
| ## 1.0.3 (1.21.10) | |
| * For 1.21.10 compatibility |
| ## 1.0.3 (1.22.10) | ||
| * For 1.22.10 compatibility |
There was a problem hiding this comment.
The changelog entry shows "1.22.10" but should be "1.21.10" to match the actual Minecraft version being released.
| ## 1.0.3 (1.22.10) | |
| * For 1.22.10 compatibility | |
| ## 1.0.3 (1.21.10) | |
| * For 1.21.10 compatibility |
1 participant
No description provided.