Conversation
|
Caution Review failedThe pull request is closed. Walkthrough액세스 토큰 기반으로 사용자 선택정보 업데이트 흐름을 변경. 컨트롤러와 서비스의 putOptional 시그니처/반환타입을 수정하고, 요청 DTO에 accessToken 필드를 추가. 새 액세스 토큰만 반환하는 NewAccessTokenResponse DTO를 신설. 쿠키 기반 리프레시 토큰 사용 로직 제거. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as User
participant C as UserController
participant S as UserService
participant T as TokenUtil/JWT
User->>C: PUT /user (phoneNumber, consent, accessToken)
C->>S: putOptional(phoneNumber, consent, accessToken)
S->>T: Parse accessToken (userId, role)
T-->>S: Claims
S->>S: 사용자 정보 업데이트(전화번호/마케팅 동의)
S->>T: 새 액세스 토큰 생성
T-->>S: newAccessToken
S-->>C: NewAccessTokenResponse(newAccessToken)
C-->>User: 200 OK + { access_token }
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 요약
토큰 재발급 로직 수정
Issue Link
#310
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit