Skip to content

Conversation

@godronus
Copy link
Collaborator

@godronus godronus commented Feb 6, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a FastEdge-specific override for StarlingMonkey’s console logging implementation to adjust how console.* output is emitted at runtime.

Changes:

  • Added a new builtin (fastedge::console_override) that provides a strong-symbol implementation of builtin_impl_console_log.
  • Added log-prefix formatting for different Console::LogType values and forces flushing after writes.
  • Registered the new builtin in runtime/fastedge/CMakeLists.txt.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
runtime/fastedge/builtins/console-override.cpp Adds a strong-symbol console log implementation and a no-op builtin install() to ensure the object is linked.
runtime/fastedge/CMakeLists.txt Registers the new fastedge::console_override builtin in the build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

align console.log functionality with proxy-wasm usage (rust friendly)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@godronus godronus merged commit 38882ab into main Feb 6, 2026
4 checks passed
@godronus godronus deleted the fix/logging branch February 6, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants