Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds KV store usage examples for both Rust and JavaScript implementations, along with updates to dependency versions across the repository to use workspace-managed dependencies and newer SDK versions.
- Adds new KV store example applications in Rust and JavaScript demonstrating usage of key-value storage APIs
- Updates SDK dependencies to use workspace management in Rust projects (fastedge 0.3.1, proxy-wasm 0.2.4)
- Updates JavaScript SDK to version 2.1.0 across all JavaScript projects
- Updates AssemblyScript dependencies and fixes imports to use the new fastedge namespace
Reviewed Changes
Copilot reviewed 37 out of 45 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/http/kv-store/* | New Rust KV store example with support for get, scan, zscan, zrange, and bfExists operations |
| javascript/src/kv-store/* | New JavaScript KV store example with TypeScript implementation and query parameter validation |
| rust/Cargo.toml | Adds workspace dependencies for fastedge and proxy-wasm |
| rust/*/Cargo.toml | Updates to use workspace-managed dependencies |
| javascript/README.md | Adds KV store link to documentation (contains incorrect path) |
| assemblyscript/* | Updates dependencies and fixes imports for new SDK structure |
| github-actions/* | Updates SDK versions to 2.1.0 |
Files not reviewed (5)
- assemblyscript/package-lock.json: Language not supported
- github-actions/multi-app-workflows/package-lock.json: Language not supported
- github-actions/single-app-workflows/package-lock.json: Language not supported
- javascript/src/mcp-server/package-lock.json: Language not supported
- javascript/src/static-assets/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@qrdl - Please read the Rust example.. it is mostly MCP server assisted.. I read it and it looks ok. It certainly works, but may not be the best implementation