fix: workflow permissions and relevance-check bypass regressions#420
Merged
greenc-FNAL merged 2 commits intojules-maintenance-fix-pr-comment-reactions-18132869807280577001from Mar 12, 2026
Conversation
…tch, pr-head-sha wiring Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [18132869807280577001] Fix
fix: workflow permissions and relevance-check bypass regressions
Mar 12, 2026
tidy-fix comment reactions4ad0275
into
jules-maintenance-fix-pr-comment-reactions-18132869807280577001
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI workflow regressions introduced after workflow consolidation by restoring required permissions for PR reaction updates, ensuring manual (workflow_dispatch) runs don’t get skipped by relevance checks, and wiring previously-declared workflow_call inputs into the change-detection path.
Changes:
- Restored
issues: writepermission to all*-fixworkflows socomplete-pr-commentcan update comment reactions. - Updated check-job
if:conditions soworkflow_dispatchruns always execute even when change detection reports no relevant changes. - Wired
pr-head-shathrough workflows intoworkflow-setup/run-change-detectionvia a newhead-refinput for accurate relevance checking when called viaworkflow_call.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/yaml-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/yaml-check.yaml | Ensures manual dispatch runs even if relevance check finds no YAML changes. |
| .github/workflows/python-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/python-check.yaml | Adds manual-dispatch bypass and wires pr-head-sha into change detection via head-ref. |
| .github/workflows/markdown-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/markdown-check.yaml | Adds manual-dispatch bypass and wires pr-head-sha into change detection via head-ref. |
| .github/workflows/jsonnet-format-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/jsonnet-format-check.yaml | Adds manual-dispatch bypass and wires pr-head-sha into change detection via head-ref. |
| .github/workflows/header-guards-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/header-guards-check.yaml | Adds manual-dispatch bypass and wires pr-head-sha into change detection via head-ref. |
| .github/workflows/coverage.yaml | Ensures manual dispatch runs even if relevance check finds no relevant changes. |
| .github/workflows/cmake-format-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/cmake-format-check.yaml | Adds manual-dispatch bypass and wires pr-head-sha into change detection via head-ref. |
| .github/workflows/cmake-build.yaml | Adds manual-dispatch/skip-relevance-check bypass and wires pr-head-sha into change detection via head-ref. |
| .github/workflows/clang-tidy-check.yaml | Ensures manual dispatch runs even if relevance check finds no relevant changes. |
| .github/workflows/clang-format-fix.yaml | Adds issues: write so fix workflow can update reactions on PR comments. |
| .github/workflows/clang-format-check.yaml | Ensures manual dispatch runs even if relevance check finds no relevant changes. |
| .github/workflows/actionlint-check.yaml | Adds manual-dispatch bypass and wires pr-head-sha into change detection via head-ref. |
| .github/actions/workflow-setup/action.yaml | Adds head-ref input and forwards it to run-change-detection. |
| .github/actions/complete-pr-comment/action.yaml | Documents the issues: write permission requirement for reaction updates. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-consolidation regressions:
issues: writewas dropped from all-fixworkflows (breaking reaction updates viacomplete-pr-comment), check jobs became skippable onworkflow_dispatch(previously always ran), andskip-relevance-check/pr-head-shaworkflow_call inputs were defined but never wired.Permissions
issues: writeto all 7-fixworkflows (clang-format-fix,cmake-format-fix,header-guards-fix,jsonnet-format-fix,markdown-fix,python-fix,yaml-fix) — required by the GitHub Reactions API used incomplete-pr-commentissues: writerequirement incomplete-pr-commentaction descriptionworkflow_dispatchbypassUpdated check job
if:conditions across 11 check workflows so manual dispatch always runs:pr-head-shawiringhead-refinput toworkflow-setup/action.yaml, passed through torun-change-detectionactionlint-check,cmake-build,cmake-format-check,header-guards-check,jsonnet-format-check,markdown-check,python-check) now forwardinputs.pr-head-shaashead-reftoworkflow-setup📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.