Forward destination_data_layer in graph_proxy::unfold#401
Open
olantwin wants to merge 1 commit intoFramework-R-D:mainfrom
Open
Forward destination_data_layer in graph_proxy::unfold#401olantwin wants to merge 1 commit intoFramework-R-D:mainfrom
olantwin wants to merge 1 commit intoFramework-R-D:mainfrom
Conversation
graph_proxy::unfold was missing the destination_data_layer parameter and used create_glue(false) which produces glue<void_tag> instead of glue<Splitter>. This meant algorithm authors could not specify the child layer for unfold, and the Splitter template was not forwarded correctly to glue::unfold. This commit forwards the parameter and construct glue<Splitter> directly, matching what framework_graph already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playing around with different data layers I noticed that it wasn't possible to specify the destination layer for an unfold. This PR attempts to fill this gap.
Comments very welcome, as I'm just starting with Phlex it's possible or even likely that I overlooked a better way to do this.
With the PR code, a registration like follows becomes possible:
m.unfold<tw::ClusterSplitter>( "find_candidates", &tw::ClusterSplitter::has_more, [](tw::ClusterSplitter const& splitter, std::size_t index) { return splitter.emit(index); }, concurrency::unlimited, "event_candidate") .input_family(product_query{ .creator = "merge_window", .layer = "time_window", .suffix = "tw_data"}) .experimental_when("tw_module:trigger") .output_products("candidate");All the best,
Oliver