Python test coverage improvements#399
Merged
knoepfel merged 13 commits intoFramework-R-D:mainfrom Mar 13, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 83.77% 84.22% +0.45%
==========================================
Files 126 128 +2
Lines 3291 3322 +31
Branches 583 564 -19
==========================================
+ Hits 2757 2798 +41
+ Misses 325 324 -1
+ Partials 209 200 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@phlexbot format |
Contributor
Author
|
@phlexbot python-fix |
Contributor
|
No automatic ruff fixes were necessary. |
Contributor
Contributor
|
Review the full CodeQL report for details. |
greenc-FNAL
approved these changes
Mar 10, 2026
Contributor
greenc-FNAL
left a comment
There was a problem hiding this comment.
CMake changes look reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python test coverage was reduced in #369 to due refactoring of the code handling various types. This code provides further cleanup by normalizing Python annotations and providing better support for Numpy. This provides two ways for better testing:
Additionally, this PR improves the support for
numpytypes. The test do not strictly usenumpytypes throughout, in order to provide for tests of C++ types as strings, but from here on out, use ofnumpytypes should be encouraged. The advantages ofnumpytypes are:np.int64, instead of implementation-definedlong.#noqaeverywhere.There is some further refactoring to make code more consistent and some Python tests are now enabled even if
cppyyis not found (they should never have been conditional on that).