Skip to content

Fix compatibility issues with addThemeVariants method in demo #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javier-godoy merged 2 commits into from
Feb 4, 2026
Merged

Fix compatibility issues with addThemeVariants method in demo #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8f8f40
fix(demo): replace use of addThemeVariants in RadioButtonGroup
paodb Feb 4, 2026
6df827d
fix(demo): replace use of addThemeVariants for Button
paodb Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/test/java/com/flowingcode/vaadin/addons/orgchart/EditChartDemo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ private VerticalLayout getEditionLayout() {
// #endif
// show-source typeSelector.setItems("Parent(root)", "Child", "Sibling");
typeSelector.setValue("Child");
typeSelector.addThemeVariants(RadioGroupVariant.LUMO_VERTICAL);
// #if vaadin eq 0
typeSelector.getThemeNames().add("vertical");
// #endif
// show-source typeSelector.addThemeVariants(RadioGroupVariant.LUMO_VERTICAL);

// New node(s) layout (dynamic)
newNodeFieldsLayout = createVerticalLayout();
Expand Down Expand Up @@ -459,8 +462,11 @@ private void clearSelectedNode() {

private Button createIconButton(VaadinIcon icon) {
Button iconButton = new Button(icon.create());
iconButton.addThemeVariants(ButtonVariant.LUMO_ICON, ButtonVariant.LUMO_SMALL,
ButtonVariant.LUMO_TERTIARY_INLINE);
// #if vaadin eq 0
iconButton.getThemeNames().addAll(Arrays.asList("icon", "tertiary-inline", "small"));
// #endif
// show-source iconButton.addThemeVariants(ButtonVariant.LUMO_ICON, ButtonVariant.LUMO_SMALL,
// show-source ButtonVariant.LUMO_TERTIARY_INLINE);
return iconButton;
}

Expand Down