Conversation
WalkthroughProject version bumped to 3.0.0-SNAPSHOT; Vaadin baseline updated to 24.8.14; several dependency versions updated; new Maven profile Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pom.xml`:
- Around line 596-610: The v25 Maven profile (profile id "v25") currently sets
<jetty.version>11.0.26</jetty.version> which is incompatible with Vaadin 25
(vaadin.version 25.0.3) because Vaadin 25 requires Jetty 12 (Servlet 6 / Jakarta
EE 11); change the jetty.version used for Vaadin 25 to a 12.x release and remove
the redundant jetty.version override from the v25 profile, or alternatively set
jetty.version to 12.x at the global properties level if all profiles can use
Jetty 12—update the <jetty.version> property accordingly and ensure only one
authoritative declaration remains.
cba8de1 to
c9ff619
Compare
|
| <dependencies> | ||
| <dependency> | ||
| <groupId>com.vaadin</groupId> | ||
| <artifactId>vaadin-dev</artifactId> |
There was a problem hiding this comment.
Regarding upgrade guide, this dependency should be optional.
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-dev</artifactId>
<optional>true</optional>
</dependency>
There was a problem hiding this comment.
Hello. Yes, we will fix this to align with idiomatic usage.
Please note that the upgrade guide's recommendation applies to applications (enabling automatic switching between local development mode and packaged production mode). In this specific case, however, the v25 profile is used solely to run the demo in dev mode for testing the add-on both with Vaadin 24 and 25.
Since add-ons themselves are not built in a specific "mode", we utilize a separate environment to test add-on integration within a production-built application.
There was a problem hiding this comment.
@javier-godoy Indeed that makes sense. Thanks for clarification.



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.