refactor: avoid use of commons.lang3

[javier-godoy]

Summary by CodeRabbit

• Chores

  • Updated Vaadin framework dependency from beta version (25.0.0-beta2) to the latest stable release (25.0.0).
  • Added optional vaadin-dev dependency to support enhanced development capabilities.

• Refactor

  • Improved internal code consistency in GoogleMap component.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Update Vaadin version to stable release (25.0.0) in the v25 profile and add a vaadin-dev optional dependency. Refactor StringUtils.isEmpty() calls in GoogleMap constructor to use a new private static isEmpty() helper method.

Changes

Cohort / File(s)	Summary
Dependency management pom.xml	Bump Vaadin version from 25.0.0-beta2 to 25.0.0; add com.vaadin:vaadin-dev as optional dependency in v25 profile
String utility refactoring src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java	Extract private static isEmpty(String) helper method; replace StringUtils.isEmpty() calls in constructor with new helper for clientId and language validation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• refactor: use lombok extension mechanism #172: Also modifies GoogleMap.java with additional refactoring using Lombok and JsonMigration changes.

Suggested reviewers

• paodb

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring to eliminate dependency on commons.lang3 by replacing StringUtils.isEmpty() with a custom helper method.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 20251223

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (1)

93-95: Consider using isEmpty() method for consistency.

The implementation is correct. For slightly improved readability, you could use s.isEmpty() instead of s.length() == 0, as both are equivalent.

🔎 Optional refinement

 private static boolean isEmpty(final String s) {
-  return s == null || s.length() == 0;
+  return s == null || s.isEmpty();
 }

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ec4b3a and 5d54a5c.

📒 Files selected for processing (2)

• pom.xml
• src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java

🔇 Additional comments (3)

pom.xml (2)

543-543: LGTM - Vaadin version stabilized.

Upgrading from beta2 to the stable 25.0.0 release is appropriate.

---

553-557: No issues identified. The vaadin-dev dependency is properly configured as optional in Vaadin 25, which is the recommended approach to exclude development tooling from production artifacts while enabling development mode during local development.

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (1)

85-90: Refactoring successfully removes StringUtils dependency.

The replacement of StringUtils.isEmpty() with the local isEmpty() helper is complete. No remaining references to StringUtils, commons-lang3 imports, or the dependency in pom.xml were found. The refactoring is clean and ready.

[mlopezFC]

LGTM