fix: add 'untagged' tag to bookmarks without tags on creation#412
Open
sgusic1 wants to merge 1 commit intoFindFirst-Development:mainfrom
Open
fix: add 'untagged' tag to bookmarks without tags on creation#412sgusic1 wants to merge 1 commit intoFindFirst-Development:mainfrom
sgusic1 wants to merge 1 commit intoFindFirst-Development:mainfrom
Conversation
sgusic1
changed the title
R-Sandor
requested changes
Jan 27, 2026
|
|
||
| // Add default "untagged" tag if user has not provided any | ||
| if (!tags.length) { | ||
| tags = [{ title: "untagged", id: -1 }]; |
Collaborator
There was a problem hiding this comment.
I would prefer it on the retrieval side rather than the submission side.
For example, the frontend when it retrieves all the bookmarks the untagged tag to the bookmark rather than saving it on the backend.
The reason this is suggested, is we then have to manage untagged bookmarks on the backend then. Such as when a user adds a tag to a bookmark that has been tagged as untagged, now we have to check the tags when tags are added and in this not an optimal option.
Author
There was a problem hiding this comment.
Got it, I’ll fix this as soon as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Checklist
What is the current behavior?
Bookmarks created without tags are not grouped under any tag.
What is the new behavior?
Treat bookmarks with no tags as if they belong to a special “untagged” tag, that way they can be listed, counted and filtered like any other tag.
Does this introduce a breaking change?
Other information