This repository was archived by the owner on Dec 23, 2022. It is now read-only.
Adding non-video/audio/subtitle streams does not work for Matroska#148
Open
mjc wants to merge 1 commit intoFallingSnow:masterfrom
mjc:dont-add-unsupported-streams
Open
Adding non-video/audio/subtitle streams does not work for Matroska#148mjc wants to merge 1 commit intoFallingSnow:masterfrom mjc:dont-add-unsupported-streams
mjc wants to merge 1 commit intoFallingSnow:masterfrom
mjc:dont-add-unsupported-streams
Conversation
Owner
|
Can you provide me documentation for this? It's my understanding that Matroska should support any data as an attachment. The code you have commented out works for attachments of font formats and images in my testing. |
|
I also have a commit fixing this issue by excluding the data stream. binair-io@11f932c . I also bumped into this issue, and others have as well : #166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the right fix but it definitely worked for me to skip these.
I think the right thing would be to have a mapping of all the supported types for Matroska.