This repository was archived by the owner on Dec 23, 2022. It is now read-only.
Make debug actually print the error when ffmpeg crashes, also fix some channel mapping stuff#134
Closed
mjc wants to merge 2 commits intoFallingSnow:masterfrom
mjc:show_ffmpeg_error
Closed
Make debug actually print the error when ffmpeg crashes, also fix some channel mapping stuff#134mjc wants to merge 2 commits intoFallingSnow:masterfrom mjc:show_ffmpeg_error
mjc wants to merge 2 commits intoFallingSnow:masterfrom
mjc:show_ffmpeg_error
Conversation
Owner
|
Thanks for the pull, poked my to check out the other pull requests. I think pull #127 by @upekshapriya, specifically https://github.com/FallingSnow/h265ize/pull/127/files#diff-b5aeacf0b0e89c4ad9316070981779a4R819, will fix the problem sufficiently, don't you? Let's see what happens with his pull first. I will take the debug fix though! Thank you. |
Contributor
Author
|
It may. I'll make a new PR with just the debug commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ffmpeg has this open issue about mapping channels correctly with libopus.
I suspect the correct fix for this is to have our own mappings for these but for now this PR at least let the encode continue and I figured I would open the discussion so I can fix this PR to do whatever is decided on a weekend.
ffmpeg channel maps (from
ffmpeg -layouts):mono:
FCstereo:
FL+FR2.1:
FL+FR+LFE3.0:
FL+FR+FC3.0(back):
FL+FR+BC4.0:
FL+FR+FC+BCquad:
FL+FR+BL+BRquad(side):
FL+FR+SL+SR3.1:
FL+FR+FC+LFE5.0:
FL+FR+FC+BL+BR5.0(side):
FL+FR+FC+SL+SR5.1:
FL+FR+FC+LFE+BL+BR5.1(side):
FL+FR+FC+LFE+SL+SR6.0:
FL+FR+FC+BC+SL+SR6.0(front):
FL+FR+FLC+FRC+SL+SRhexagonal:
FL+FR+FC+BL+BR+BC6.1:
FL+FR+FC+LFE+BC+SL+SR6.1(back):
FL+FR+FC+LFE+BL+BR+BC6.1(front):
FL+FR+LFE+FLC+FRC+SL+SR7.0:
FL+FR+FC+BL+BR+SL+SR7.0(front):
FL+FR+FC+FLC+FRC+SL+SR7.1:
FL+FR+FC+LFE+BL+BR+SL+SR7.1(wide):
FL+FR+FC+LFE+BL+BR+FLC+FRC7.1(wide-side):
FL+FR+FC+LFE+FLC+FRC+SL+SRopus follows vorbis channel ordering
stereo:
L+R3ch:
L+C+R4ch:
FL+FR+RL+RR5ch:
FL+C+FR+RL+RR5.1:
FL+C+FR+RL+RR+LFE6.1:
FL+C+FR+SL+SR+RC+LFE7.1:
FL+C+FR+SL+SR+RL+RR+LFEIt looks like just overriding 5.1(side) to 5.1 is fine but I'm not so sure about most of the other cases