feat: Support nested declarations in fuzzy attributes#1144
Open
rodrigobnogueira wants to merge 1 commit intoFactoryBoy:masterfrom
Open
feat: Support nested declarations in fuzzy attributes#1144rodrigobnogueira wants to merge 1 commit intoFactoryBoy:masterfrom
rodrigobnogueira wants to merge 1 commit intoFactoryBoy:masterfrom
Conversation
Recursive resolution of declarations in BaseFuzzyAttribute. Fixes FactoryBoy#1050 - BaseFuzzyAttribute now resolves nested declarations (e.g. LazyAttribute) - Updated FuzzyChoice, FuzzyInteger, FuzzyFloat, FuzzyDate, FuzzyDateTime - Added tests for nested declarations in all fuzzy types - Updated documentation
73464eb to
31e43ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables
factory.fuzzyattributes to correctly evaluate nested declarations (e.g.LazyAttribute,SelfAttribute,LazyFunction) when passed as arguments.Fixes
FuzzyChoicedoes not acceptSelfAttribute.Changes
_resolvehelper mechanism toBaseFuzzyAttributeto recursively evaluate declarations passed as parameters.FuzzyChoice: Now resolves choices generator.FuzzyInteger,FuzzyDecimal,FuzzyFloat: Now resolve low and high bounds.FuzzyDate: Now resolvesstart_dateandend_date.FuzzyDateTime: Now resolvesstart_dtandend_dt.FuzzyDateandFuzzyDateTimelogic was adjusted to defer validation untilfuzz()time if (and only if) declarations are used, ensuring existing usage (e.g.end_date=None) remains unchanged.Verification
New Tests: Added comprehensive test cases for:
Suite: Ran full test suite; all 457 tests passed.
Linting: Verified compliance with project standards (PEP8/flake8, isort).
Docs: Marked the feature as "Accomplished" in the ideas list.