Explicitly export values on factory namespace#1114
Open
DavidCain wants to merge 1 commit intoFactoryBoy:masterfrom
Open
Explicitly export values on factory namespace#1114DavidCain wants to merge 1 commit intoFactoryBoy:masterfrom
DavidCain wants to merge 1 commit intoFactoryBoy:masterfrom
Conversation
Now that `factory-boy` exports its types, mypy will fail in strict mode if using the `factory` namespace. Specifically, `--no-implicit-reexport` flags references to `factory.Factory` (and other similar values) as being implicitly exported. We can instead *explicitly* export these objects. As a benefit, anybody who uses the ill-advised `from factory import *` will now at least no longer have `__author__` and such pollute their namespace. https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport
|
Just a mild bump that this feels like a useful thing to get in 🙇 |
Author
|
@rbarrois - any thoughts about this proposed change? |
|
@rbarrois can we have it merged? Everyone was using |
|
This would be really nice to get merged. It seems like a fairly low risk change since it only updates the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
factory-boyexports its types, mypy will fail in strict modeif using the
factorynamespace. Specifically,--no-implicit-reexportflags references to
factory.Factory(and other similar values) asbeing implicitly exported:
We can instead explicitly export these objects. As a benefit, anybody
who uses the ill-advised
from factory import *will now at least nolonger have
__author__and such pollute their namespace.https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport