feat: Add generic support for SQLAlchemyModelFactory#1096
Closed
forana wants to merge 1 commit intoFactoryBoy:masterfrom
forana:master
Closed
feat: Add generic support for SQLAlchemyModelFactory#1096forana wants to merge 1 commit intoFactoryBoy:masterfrom forana:master
forana wants to merge 1 commit intoFactoryBoy:masterfrom
forana:master
Conversation
Author
|
Closing in favor of #1060 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the typing support added in #903 to allow
SQLAlchemyModelFactoryto specify its generic type as well.(We have some custom extensions in use on top of
SQLAlchemyModelFactory, which make use of generics - the additions from #903 are a breaking change for us because it creates an MRO issue withGeneric)