Make default color for django.ImageField random#1086
Make default color for django.ImageField random#1086TheSuperiorStanislav wants to merge 1 commit intoFactoryBoy:masterfrom
Conversation
f93e7dc to
17415eb
Compare
17415eb to
17faf9b
Compare
kingbuzzman
left a comment
There was a problem hiding this comment.
I'm not in favor of this approach, as I generally prefer to avoid introducing additional uncertainty into our tests. If you'd like to do this locally and call it "RandomImageField" or "FuzzyImageField", that's totally fine on your end. However, I don't think it makes sense to add this to the main repository, as it would require everyone to be aware of it and potentially adjust their code to accommodate it.
To be honest it's hard to imagine test breaking because of color change. Currently default it's not explict, if test relies on specific color, i think it should be specified in Factory definition. I mean faker |
No description provided.