#71 Move documentWriter up for the Flow generation#75
Open
JThoennes wants to merge 3 commits intoFIXTradingCommunity:masterfrom
Open
#71 Move documentWriter up for the Flow generation#75JThoennes wants to merge 3 commits intoFIXTradingCommunity:masterfrom
JThoennes wants to merge 3 commits intoFIXTradingCommunity:masterfrom
Conversation
Author
|
@donmendelson please consider merging this PR because it completes my previous commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same applies to the generation of "Flow" elements. Instead of duplicating the
documentWriter.write(context)it should be moved up. Deleted the second call. Sorry for the omission.