Add address cache generated by scraper and pull event locations from this#247
Open
EthShaw wants to merge 2 commits intoFIRSTMap:masterfrom
Open
Add address cache generated by scraper and pull event locations from this#247EthShaw wants to merge 2 commits intoFIRSTMap:masterfrom
EthShaw wants to merge 2 commits intoFIRSTMap:masterfrom
Conversation
Since TBA is no longer looking up geolocations based on addresses for events, we will have to do that with the scraper. This takes those geolocated addresses, puts them in a JSON file, and uses FIRSTMap to For events that lack a valid address, GPS coordinates are still put in event_fallback_locs.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address #246, I propose we have an "address cache" that contains the GPS lookup locations for each address. The scraper can be modified to populate this. The reason I am proposing caching address location instead of event locations is that from year to year, many events will keep the same addresses.
For events that have seriously malformed or missing addresses, the
event_fallback_locs.jsonfile can still be used.I have made modifications to the scraper to generate this file, but it still needs some work to clean things up (PR forthcoming). I figured it best to go ahead and put this up for review so the event addresses can be fixed on the map. I am open to other suggestions for how to handle this TBA API change as well.
@ErikBoesen requesting review