Conversation
📝 WalkthroughWalkthroughThis change adds documentation for the balance snippet file structure, detailing naming conventions, header formatting, parameter change entries, and glossary definitions for key metadata fields. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I might be mistaken, but I think we do not yet link to https://faforever.github.io/fa/ anywhere. We should do that. Can you maybe find a good place in the main readme? |
|
Looks good. It could be beneficial to explicitly specify which database should be used for the formatted unit name. I use Spooky. |
I don't know where to put it because a lot of the website content overlaps with the linked markdown files in the readme. |
I explicitly wrote the format for future-proofing. Referencing spooky db feels awkward because etfreeman db is replacing it and it doesn't have that exact same format. Using spooky db just to copy paste the format while using etfreeman db for stats is awkward as well. |
Description of the proposed changes
Documents balance snippet format.
Checklist
- [ ] Changes are annotated, including comments where useful- [ ] Changes are documented in a changelog snippet according to the guidelines.Summary by CodeRabbit