chore: update maps to latest version of ethereal engine#12
Draft
aditya-mitra wants to merge 13 commits intomainfrom
Draft
chore: update maps to latest version of ethereal engine#12aditya-mitra wants to merge 13 commits intomainfrom
aditya-mitra wants to merge 13 commits intomainfrom
Conversation
HexaField
suggested changes
Jun 3, 2023
engine/MapReceptor.ts
Outdated
| return s.merge({ | ||
| center: action.centerPoint, | ||
| switch(action.type) { | ||
| case 'map.INITIALIZE': return state.merge({ |
Contributor
There was a problem hiding this comment.
this should be refactored to use the defineActionQueue API
engine/MapUpdateSystem.ts
Outdated
| const $previousMapCenterPoint: LongLat = Array(2) | ||
|
|
||
| export default async function MapUpdateSystem(world: World): Promise<System> { | ||
| export default async function MapUpdateSystem(): Promise<any> { |
Contributor
There was a problem hiding this comment.
systems now use defineSystem which takes execute as an argument. any async logic should be done in a reactor on the system defintion
HexaField
reviewed
Jun 3, 2023
HexaField
suggested changes
Jun 20, 2023
chore: added debug statements in functions and phases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6