Table_exists: expect table name, not model name#205
Open
skalee wants to merge 2 commits intoErlyORM:masterfrom
Open
Table_exists: expect table name, not model name#205skalee wants to merge 2 commits intoErlyORM:masterfrom
skalee wants to merge 2 commits intoErlyORM:masterfrom
Conversation
1. Make API compatible with PostgreSQL adapter 2. Make it working when called with schema_migrations 3. It generally makes more sense to work with SQL table names, models can be renamed or deleted which would break old migrations.
skalee
force-pushed
the
fix-mysql-table_exists
branch
from
63f2d29 to
830cac6
Compare
Author
|
Sorry for premature pull request. This fixes one bug but |
This is SELECT query, so MySQL will rather return
{data,{mysql_result, ...}} tuple.
Author
|
This will work now. However it still logs error (in |
Author
|
Guys, without these fixes migrations do not work with mysql adapter at all. |
Contributor
|
Please consider merging this PR since without it migrations in MySQL won't work. |
|
i have this same error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
models can be renamed or deleted which would break old migrations.
This fixes #198.