Open
Conversation
• whitespace cleanup / harmonisation • const • some ordering without side effects • comments • correct type *_MAX constant
(cherry picked from commit 34ecd11)
still works: 58.1 Transmit rate = 202059kbps, PLR = 0.00%( 0.00%), RTT = 0.000s, Queue delay = 0.000s
some contributors use git implementations that utterly hose symlinks
(and on the wrong end of the connection)
because the latter can write to it
it now takes only the local port# to bind; the first sender “wins” and may use the “connection”
Contributor
Author
|
I’ve added This makes it possible to test asymmetric connections that are one-sided behind NAT. |
Check for parameter correctness in sender app.
Contributor
Contributor
Author
|
Hi Ingemar,
1) Have you verified that the code works as intended with all the
proposed fixes ?
yes, I’m easily reaching the same bandwidth as without these
modifications on an 100 Mbit/s link and 200+ on Gbit links.
2) Is it possible to put all white space changes as a separate commit?,
it would make it easier to review the proposed changes.
They are separate commits, but you can also do:
git fetch origin pull/47/head:refs/pr/47 # to fetch the changes
git diff -w master..refs/pr/47 # to view ignoring WS changes
Since this PR is based on top of #46 maybe review+merge that first,
then this PR will be reduced to the necessities.
Thanks,
//mirabilos
--
Infrastrukturexperte • tarent solutions GmbH
Am Dickobskreuz 10, D-53121 Bonn • http://www.tarent.de/
Telephon +49 228 54881-393 • Fax: +49 228 54881-235
HRB AG Bonn 5168 • USt-ID (VAT): DE122264941
Geschäftsführer: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
|
only variables of volatile sig_atomic_t type are signal-safe…
Contributor
|
Hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of the changes in #46 this adds NAT support to the bandwidth tester:
sockaddr_inis initialised withAF_UNSPECto signal it’s not fully initialised yetrecvfrom(2)/recvmsg(2)msg_nameand “records” that as outgoing feedback addressThis has been tested with the receiver on a public IPv4 and the sender behind NAT; it should also work with the sender behind multiple NATs as on Campus-IT PoC.
The totally inefficient and not-working NAT punching from the existing code has been removed as well.