Check for parameter correctness in sender app.#40
Open
danesh-d wants to merge 1 commit intoEricssonResearch:masterfrom
Open
Check for parameter correctness in sender app.#40danesh-d wants to merge 1 commit intoEricssonResearch:masterfrom
danesh-d wants to merge 1 commit intoEricssonResearch:masterfrom
Conversation
mirabilos
reviewed
Jun 27, 2022
| DECODER_IP = argv[ix];ix++; | ||
| DECODER_PORT = atoi(argv[ix]);ix++; | ||
|
|
||
| if (argc > (ix + 1)) { |
mirabilos
approved these changes
Jun 27, 2022
Contributor
mirabilos
left a comment
mirabilos
left a comment
There was a problem hiding this comment.
lgtm other than the bad indentation in the last hunk
mirabilos
added a commit
to qvest-digital/scream
that referenced
this pull request
Jun 29, 2022
Check for parameter correctness in sender app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@IngJohEricsson I added parameter check for sender as well. It would be great if the app can be executed with correct parameters and then it is verified that with correct parameters it works as it should.