feat: integrate eppo module with android-sdk-framework (v3 → v4 migration)#249
Draft
typotter wants to merge 5 commits intopr1-add-framework-modulefrom
Draft
feat: integrate eppo module with android-sdk-framework (v3 → v4 migration)#249typotter wants to merge 5 commits intopr1-add-framework-modulefrom
typotter wants to merge 5 commits intopr1-add-framework-modulefrom
Conversation
…ation)
Migrate EppoClient from v3 SDK to v4 framework, resolving all test failures.
## Major Changes
### EppoClient Migration
- Extend AndroidBaseClient from framework instead of BaseEppoClient
- Remove old ConfigurationStore, ConfigCacheFile, BaseCacheFile (now in framework)
- Add dependency on android-sdk-framework module
- Remove v3 sdk-common-jvm dependency
### New Components
- OkHttpEppoClient: HTTP client implementation with logging
- JacksonConfigurationParser: JSON parsing for v4 format
- Jackson adapters for EppoValue, FlagConfigResponse, dates, etc.
### Test Infrastructure Fixes
- TestConfigCacheFile: Fix filename to match framework (eppo-sdk-flags-{suffix}.ser)
- Fix waitForPopulatedCache(): Remove incorrect .ser suffix (already in filename)
- Fix unclosed OutputStreams: Add try-with-resources (3 locations)
- Simplify testDifferentCacheFilesPerKey: Copy actual cache instead of custom JSON
- Add OutputStream import
### Example App Updates
- Add CustomClientActivity demonstrating custom HTTP client
- Add GsonConfigurationParser and HeaderInjectingEppoClient examples
## Test Results
- All 46 instrumentation tests passing locally
- Framework module builds independently
- Eppo module builds with v4 dependencies
- Fix TestConfigCacheFile.cacheFileName() to use correct format (eppo-sdk-flags-{suffix}.ser)
- Simplify testDifferentCacheFilesPerKey to copy actual cache instead of custom JSON
- Fix unclosed OutputStreams with try-with-resources (3 locations)
These fixes resolve all test failures and ensure 46/46 tests pass.
…I 26-32 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the eppo module from v3 SDK to v4 framework, completing the integration started in #248.
Dependencies
Depends on: #248 (must be merged first)
Major Changes
EppoClient Migration (v3 → v4)
New v4 Components
Test Infrastructure Fixes (Critical for 46/46 tests passing)
eppo-sdk-flags-cloud.eppo.api.Configuration-{suffix}.bineppo-sdk-flags-{suffix}.ser.sersuffixExample App Enhancements
Test Results
Migration Notes
.serextension (Java serialization)