Tweak handling of incomplete pairwise alignment stats #1142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR would tweak handling of incomplete pairwise alignment stats by:
fetch_pairwise_inputmethod ofEnsEMBL::Web::Document::HTML::Compara::MLSSto itsrender_pairwisemethod. Without this change, the conditional statement checking for alignment parameters on line 202 of modules/EnsEMBL/Web/Document/HTML/Compara/MLSS.pm never evaluates to false for LastZ. Consequently the message, "No configuration parameters are available.", is not shown even when no parameters have been stored for a LastZ alignment, because assignment of the default scoring matrix beforehand ensureskeys %$blastz_parametersis nonempty.ensembl-webcode/modules/EnsEMBL/Web/Document/HTML/Compara/MLSS.pm
Line 202 in b5c4e5f
@orderarray to keep only those parameter settings available for display.Views affected
This would affect pairwise whole-genome alignment stats pages.
Example pairwise alignment stats pages:
Possible complications
Changing method
EnsEMBL::Web::Document::HTML::Compara::MLSS::fetch_pairwise_inputso that it does not assign a default scoring matrix could change the behaviour of this method if it is called outside this module.However, I haven't been able to find any use of this method outside the
Compara::MLSSmodule.Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)