Add target-ability to 'Next' button in select crypto scene#4256
Open
Add target-ability to 'Next' button in select crypto scene#4256
Conversation
Update jest test
peachbits
requested changes
Jun 12, 2023
|
|
||
| const value = selectedItems[key] | ||
| const accessibilityHint = sprintf(lstrings.create_wallet_hint, displayName) | ||
| const accessibilityState = { checked: value, selected: value } |
Contributor
There was a problem hiding this comment.
Is selected still necessary here?
| <View style={styles.bottomButton}> | ||
| <MainButton label={lstrings.string_next_capitalized} type="primary" marginRem={[0, -0.5]} onPress={handleNext} alignSelf="center" /> | ||
| </View> | ||
| <MainButton label={lstrings.string_next_capitalized} type="primary" marginRem={[0, -0.5]} onPress={handleNext} alignSelf="center" /> |
Contributor
There was a problem hiding this comment.
This appears to be a non-functional cleanup. If that's the case it should be in a separate commit at the beginning
| alignSelf: 'center', | ||
| bottom: theme.rem(1), | ||
| position: 'absolute' | ||
| bottomArea: { |
Contributor
There was a problem hiding this comment.
were these changes tested with the keyboard visible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
none
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have: