Correct Snow precipitation

[Crystal-szj]

Description

Closes #279
Closes #280
Closes #283
Relates #281

Checklist

• Add a reference to related issues.
• @mentions of the person or team responsible for reviewing proposed changes.
• This pull request has a descriptive title.
• Code is written according to the guidelines.
• The checks by MISS_HIT style checker and
  linter, below the pull request, are
  successful (green).
• Documentation is available.
• Add changes to the changelog file under section Unreleased.
• Model runs successfully, see tests.
• Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

[Crystal-szj]

Hi @MostafaGomaa93, Thanks for your efforts.
Could you please add the definitions of input and output variables in the functions related to your changes (add references if possible)? Additionally, for the new-added variables, let's follow the MATLAB Guidelines 2.0 about naming conventions

[Crystal-szj]

See my comment below.

[Crystal-szj]

Thank you, @MostafaGomaa93, for your efforts. I tested your branch and it works well. I ran 10 timesteps against main and correct_precip_snow_backup to compare the results with the groundwater option turned off. The results are exactly the same.

Hi @yijianzeng, we need your review to unlock the merge. Could you please review the changes Mostafa made to correct the calculation of precipitation/snow when the soil temperatures are below zero?

[yijianzeng]

Thank you, @MostafaGomaa93, for your efforts. I tested your branch, and it works well. I ran 10 timesteps against main and correct_precip_snow_backup to compare the results with the groundwater option turned off. The results are the same.

@Crystal-szj, does it make sense to post the test results after you, Mostafa, or others have done this step?

[Crystal-szj]

Thank you, @MostafaGomaa93, for your efforts. I tested your branch, and it works well. I ran 10 timesteps against main and correct_precip_snow_backup to compare the results with the groundwater option turned off. The results are the same.

@Crystal-szj, does it make sense to post the test results after you, Mostafa, or others have done this step?

Hi @yijianzeng, thanks for your suggestions. I have added the comparison here.

[yijianzeng]

The variable name is suggested to change from Infiltration to effectivePrecip, which has been done.