Skip to content

CMORize CCI LST - Microwave products#4257

Open
morobking wants to merge 19 commits intomainfrom
cmorize_cci_mw_lst
Open

CMORize CCI LST - Microwave products#4257
morobking wants to merge 19 commits intomainfrom
cmorize_cci_mw_lst

Conversation

@morobking
Copy link
Contributor

@morobking morobking commented Nov 20, 2025

Description


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script


To help with the number of pull requests:

@morobking
Copy link
Contributor Author

Unsure how to correct these comments from Prospector:
cmorizers/data/formatters/datasets/esacci_lst.py
cmorizers/data/formatters/datasets/esacci_lst.py
Line: 50
mccabe: MC0001 / cmorization is too complex (16)
pylint: unused-argument / Unused argument 'cfg_user' (col 38)
pylint: too-many-arguments / Too many arguments (6/5)
pylint: too-many-locals / Too many local variables (22/15)
pylint: too-many-positional-arguments / Too many positional arguments (6/5)
Line: 68
pylint: logging-fstring-interpolation / Use lazy % formatting in logging functions (col 16)

Line 50: are the unused arguments sent into the function by ESMValTool, or can they be removed?
Line 68: Don't know how to fix this.

@morobking
Copy link
Contributor Author

I've re-written this to handle ascending and descending better and independently.
See issue #4280

@morobking
Copy link
Contributor Author

@axel-lauer I believe this is now ready at least for the CMUG OWP5.2 and OWP5.9 work.
A single yml file has all four sensors needed, and the python will look over ascending and descending. I've used the ideas from issue #4280 to give a different filename to the sensor/direction pairs.
No change to time is done, overpass time is as an attribute in the cube.
This code I've tested on the SSMI and ASMR MW data. Code has some things left as comments to give backward computability to older CCI LST versions.
Code should work with monthly but not tested, and should work with IR LST from CCI using DAY and NIGHT instead of ASCENDING and DESCENDING.

This is a slightly different way of doing thing than before. Not yet tested with the uncertainty variables but there is not variable name dependency in the python - just looking at whatever is passed from the yml.

@morobking morobking marked this pull request as ready for review January 21, 2026 10:04
@morobking morobking requested a review from a team as a code owner January 21, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update and/or add ESA CCI datasets required for CMUG OWP4.3

1 participant