Support SDT for GPIO expander#2
Open
nhw76 wants to merge 3 commits intoDigilent:genesys-zu_2025.1from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation just fails at runtime if you're in the SDT flow, as everyone on 2025.1 and up now is, and FSBL initialization fails overall as a result - the PL doesn't ever really get properly initialized even though code that just runs on the PS seems to work.
I haven't tested this in any real depth, but this change at least allows the board to come up for me now with the SDT-based flow from XSA-to-Vitis-Unified in 2025.1.
I imagine the same change would be desirable on the 2025.2 branch.