Skip to content

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Jan 30, 2026

No description provided.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (7b10cc3) to head (2cc9068).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          43       43           
  Lines        2783     2783           
=======================================
  Hits         2645     2645           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw changed the title Remove dependency on scanspec chore: Remove dependency on scanspec Jan 30, 2026
@tpoliaw tpoliaw marked this pull request as ready for review January 30, 2026 17:44
@tpoliaw tpoliaw requested a review from a team as a code owner January 30, 2026 17:44
@ZohebShaikh
Copy link
Contributor

I think this can be move to dev dependencies, but should not be remove because
this was added because scanspec plans were not running in blueapi out of the box, so we added a test to specifically test it. (When there were lot of pydantic changes that were breaking scanspec)

If this happens we will not be able to know if the latest scanspec is working with blueapi.

@tpoliaw
Copy link
Contributor Author

tpoliaw commented Feb 2, 2026

This is still testing if blueapi can run scanspec scans, it's just not testing the serialization part which isn't normally used by the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants