feat(sys): allow skipping WASI SDK setup#648
Open
diogotcorreia wants to merge 4 commits intoDelSkayn:masterfrom
Open
feat(sys): allow skipping WASI SDK setup#648diogotcorreia wants to merge 4 commits intoDelSkayn:masterfrom
diogotcorreia wants to merge 4 commits intoDelSkayn:masterfrom
Conversation
Author
|
I've tested this change by building https://github.com/extism/js-pdk with Nix and it works fine. |
richarddd
requested changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently rquickjs-sys forces the WASI SDK to be used. However, in nixpkgs we do not use the WASI SDK but instead use the WASI libc directly. During our builds,
CCandARare already pointing to the correct binaries.At the moment we are creating a temporary structure that resembles the WASI SDK just so the build succeeds, but it would be better if we didn't have to.
Therefore I added an env variable (
RQUICKJS_SYS_NO_WASI_SDK, naming suggestions are welcome) that skips setup of the WASI SDK and places the burden of configuring the environment on whoever is building instead.Checklist
Created unit tests for my feature if needed