Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the DJ MCP server and Claude Code integration with several new features:
New MCP Tool:
get_query_planThis tool calls
GET /sql/measures/v3/to expose the DJ query execution plan. This shows how a set of metrics decomposes into grain groups (sets of metrics that share a dimensional grain and are computed in one SQL query), the atomic aggregation components within each group, and the combiner expressions that reassemble them into final metric values. This is useful for debugging unexpected results, understanding multi-metric query structure, and validating semantic model design.Enhanced
search_nodesAdded five new filters, all wired through to findNodes in the GraphQL API:
tags: filter to nodes tagged with all specified tag namesstatuses: filter by validity status (valid/invalid)mode: filter by published or draftowned_by: filter to nodes owned by a specific user/emailhas_materialization: return only nodes with materializations configuredget_common(replacesget_common_dimensions)Bidirectional semantic compatibility lookup in a single tool:
commonDimensionsquery: what dimensions are shared across all those metrics?GET /dimensions/common/?node_type=metric: what metrics can be queried by all those dimensions?dj setup-claudesubagent installationsetup-claudenow also installs a Claude Code subagent at~/.claude/agents/dj.mdwith the datajunction skill preloaded. Controlled with--agents / --no-agentsflags (default: on). The subagent surfaces the full DJ skill to any Claude Code session automatically.Skill documentation updates
get_query_planinstead ofbuild_metric_sqlTest Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan