Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 31, 2024
Closed
bcmyers
force-pushed
the
brian.myers/241230/misc4
branch
from
0f32c18 to
031409e
Compare
bcmyers
force-pushed
the
brian.myers/241230/misc5
branch
from
5b28f7c to
628605a
Compare
bcmyers
force-pushed
the
brian.myers/241230/misc4
branch
from
031409e to
0ea62ff
Compare
bcmyers
force-pushed
the
brian.myers/241230/misc5
branch
from
628605a to
e12c2e9
Compare
This was referenced Jan 5, 2025
joneshf-dd
approved these changes
Jan 31, 2025
Contributor
joneshf-dd
left a comment
joneshf-dd
left a comment
There was a problem hiding this comment.
Looks good for Language Tools!
One potential ❓. But don't block if it's not relevant.
|
|
||
| pkg_go_binary_multiple_platforms( | ||
| name = "ocitool", | ||
| go_binary = ["//go/cmd/ocitool:go_default_library"], |
Contributor
There was a problem hiding this comment.
❓ question: Is this supposed to be a label? If so, here's a quick suggestion to fix it:
Suggested change
| go_binary = ["//go/cmd/ocitool:go_default_library"], | |
| go_binary = "//go/cmd/ocitool:go_default_library", |
Contributor
There was a problem hiding this comment.
Also, maybe we either slap a build_test on this, or do bazel build //... in the ci job to catch this sort of stuff?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize file layout.