Skip to content

feat(stats_exporter)!: add process tags to CSS payloads#1709

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
vianney/add-process-tags-to-stats
Mar 11, 2026
Merged

feat(stats_exporter)!: add process tags to CSS payloads#1709
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomainfrom
vianney/add-process-tags-to-stats

Conversation

@VianneyRuhlmann
Copy link
Contributor

@VianneyRuhlmann VianneyRuhlmann commented Mar 11, 2026

What does this PR do?

Add support for process tags in CSS payload. The process tags must be set at creation of the trace exporter and can't be updated without recreating the trace exporter

Motivation

Process tags should be included in CSS payloads

Additional Notes

This PR does not include setting the process tags on spans exporter by the stats exporter this can be done in the future but is out of the scope of this PR.

How to test the change?

Added check for the process tags in unit tests.

@VianneyRuhlmann VianneyRuhlmann requested a review from a team as a code owner March 11, 2026 13:46
@github-actions
Copy link

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/vianney/add-process-tags-to-stats

Summary by Rule

Rule Base Branch PR Branch Change
unwrap_used 3 3 No change (0%)
Total 3 3 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
libdd-data-pipeline/src/stats_exporter.rs 1 1 No change (0%)
libdd-data-pipeline/src/trace_exporter/mod.rs 2 2 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 28 28 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 208 208 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

Copy link
Contributor

@dubloom dubloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
LGTM

@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Mar 11, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.63 MB 8.63 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 100.28 MB 100.29 MB +0% (+7.57 KB) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 116.94 MB 116.96 MB +.01% (+18.00 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.21 MB 11.21 MB +0% (+160 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.16 MB 27.17 MB +0% (+2.50 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.61 KB +.45% (+354 B) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.03 MB 186.02 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.14 MB 917.15 MB +0% (+8.96 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.94 MB +0% (+1.00 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.61 KB +.45% (+354 B) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.77 MB 24.77 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.43 MB 51.44 MB +.01% (+5.61 KB) 🔍
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB +0% (+1.50 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.80 KB +.45% (+360 B) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.23 MB 190.23 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.80 MB 900.81 MB +0% (+8.02 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB +.01% (+1.50 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.80 KB +.45% (+360 B) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.51 MB 26.52 MB +.02% (+8.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.05 MB 47.06 MB +.01% (+6.42 KB) 🔍
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 87.50 MB 87.50 MB +0% (+6.45 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.21 MB 10.21 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 109.81 MB 109.83 MB +.01% (+13.17 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.95 MB 11.95 MB +0% (+112 B) 👌

@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 11, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 25deff0 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@VianneyRuhlmann VianneyRuhlmann changed the title feat(stats_exporter): add process tags to CSS payloads feat!(stats_exporter): add process tags to CSS payloads Mar 11, 2026
@VianneyRuhlmann VianneyRuhlmann force-pushed the vianney/add-process-tags-to-stats branch from a2413ee to 25deff0 Compare March 11, 2026 14:47
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 73.80952% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.16%. Comparing base (3f3efef) to head (25deff0).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
+ Coverage   71.03%   71.16%   +0.13%     
==========================================
  Files         427      429       +2     
  Lines       62962    63539     +577     
==========================================
+ Hits        44722    45219     +497     
- Misses      18240    18320      +80     
Components Coverage Δ
libdd-crashtracker 62.36% <ø> (-0.07%) ⬇️
libdd-crashtracker-ffi 16.56% <ø> (-0.93%) ⬇️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 87.82% <73.80%> (-0.21%) ⬇️
libdd-data-pipeline-ffi 74.15% <62.06%> (-1.57%) ⬇️
libdd-common 79.73% <ø> (ø)
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.35% <ø> (ø)
libdd-profiling 81.60% <ø> (ø)
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 32.49% <ø> (+0.01%) ⬆️
datdog-sidecar-ffi 7.81% <ø> (+0.07%) ⬆️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 91.80% <ø> (-2.90%) ⬇️
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.08% <ø> (ø)
datadog-tracer-flare 90.45% <ø> (+1.49%) ⬆️
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VianneyRuhlmann VianneyRuhlmann changed the title feat!(stats_exporter): add process tags to CSS payloads feat(stats_exporter)!: add process tags to CSS payloads Mar 11, 2026
@VianneyRuhlmann
Copy link
Contributor Author

/merge --cancel

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 11, 2026

View all feedbacks in Devflow UI.

2026-03-11 16:18:13 UTC ℹ️ Start processing command /merge --cancel

@gyuheon0h
Copy link
Contributor

/merge --cancel

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 11, 2026

View all feedbacks in Devflow UI.

2026-03-11 16:24:36 UTC ℹ️ Start processing command /merge --cancel

Copy link
Contributor

@hoolioh hoolioh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit e6f8ad8 into main Mar 11, 2026
178 of 184 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the vianney/add-process-tags-to-stats branch March 11, 2026 17:08
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Mar 11, 2026
# What does this PR do?

Bump to 29.0.0

[feat(profiling)!: add Tracepoint sample type](#1676)
[feat(obfuscation/redis): Reach feature parity on redis obfuscation [APMSP-2668]](#1632)
[fix(sidecar): Handle backpressure more gracefully](#1682)
[feat(trace-protobuf)!: Add two fields to ClientGroupedStats [SVLS-8627]](#1630)
[chore: exclude libdatadog from ADMS auto generated PRs for dependency updates](#1688)
[chore(ci): run crashtracking ffi example tests in CI](#1687)
[fix(crashtracking): use libunwind to unwind frames](#1663)
[feat: publish tracer metadata as OTel process ctx](#1658)
[ci: run thread count test in own process](#1693)
[feat(obfuscation/json): Init json obfuscation [APMSP-2665]](#1635)
[chore(ci): add final_status property on junit XML [APMSP-2610]](#1681)
[refactor(data-pipeline-ffi): move macro definitions for better reuse](#1699)
[fix(obfuscation/memcached): fuzzing fix](#1695)
[ci: replace use of cargo cross for centos7 tests](#1675)
#1702 (comment)
[feat(stats_exporter)!: add process tags to CSS payloads](#1709)

# Motivation

I mainly am creating this to use the new unwinding from ucontext for crashtracking

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.


[APMSP-2668]: https://datadoghq.atlassian.net/browse/APMSP-2668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[SVLS-8627]: https://datadoghq.atlassian.net/browse/SVLS-8627?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-2665]: https://datadoghq.atlassian.net/browse/APMSP-2665?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: gyuheon.oh <gyuheon.oh@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants