Skip to content

ci: run thread count test in own process#1693

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
gyuheon0h/subprocess-thread-count
Mar 9, 2026
Merged

ci: run thread count test in own process#1693
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
gyuheon0h/subprocess-thread-count

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Mar 9, 2026 •
edited
Loading

What does this PR do?

We had a test to test a util function that counts the number of threads running. It did this by counting the number of threads in the beginning, spawning N threads, then checking that there are (# at beginning + N threads) at the end. This test is flaky, because cargo tests are run in parallel, and threads from other tests running get counted in the beginning, but may finish and not be present when checked after N threads are spawned.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@gyuheon0h Graphite App
Copy link
Contributor Author

gyuheon0h commented Mar 9, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title subprocess thread count ci: run thread count test in own process Mar 9, 2026
@gyuheon0h gyuheon0h marked this pull request as ready for review March 9, 2026 14:46
@gyuheon0h gyuheon0h requested a review from a team as a code owner March 9, 2026 14:46
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.06%. Comparing base (79f879e) to head (1094da4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1693      +/-   ##
==========================================
+ Coverage   71.05%   71.06%   +0.01%     
==========================================
  Files         427      427              
  Lines       62963    62962       -1     
==========================================
+ Hits        44738    44746       +8     
+ Misses      18225    18216       -9
Components Coverage Δ
libdd-crashtracker 62.42% <ø> (-0.02%) ⬇️
libdd-crashtracker-ffi 17.49% <ø> (ø)
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 88.02% <ø> (ø)
libdd-data-pipeline-ffi 75.72% <ø> (ø)
libdd-common 79.73% <92.00%> (-0.01%) ⬇️
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.47% <ø> (+0.11%) ⬆️
libdd-profiling 81.60% <ø> (ø)
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 32.47% <ø> (ø)
datdog-sidecar-ffi 7.73% <ø> (ø)
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.69% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.08% <ø> (ø)
datadog-tracer-flare 88.95% <ø> (ø)
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the common label Mar 9, 2026
@pr-commenter
Copy link

pr-commenter bot commented Mar 9, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-03-09 17:40:36

Comparing candidate commit 1094da4 in PR branch gyuheon0h/subprocess-thread-count with baseline commit 79f879e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.089µs 146.250µs ± 1.670µs 146.021µs ± 0.548µs 146.568µs 147.633µs 151.636µs 162.839µs 11.52% 6.224 53.361 1.14% 0.118µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.018µs; 146.481µs] or [-0.158%; +0.158%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.068ms 14.119ms ± 0.035ms 14.113ms ± 0.015ms 14.128ms 14.189ms 14.256ms 14.316ms 1.44% 2.400 8.231 0.25% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.114ms; 14.123ms] or [-0.035%; +0.035%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 717.059µs 718.434µs ± 0.736µs 718.273µs ± 0.370µs 718.823µs 719.712µs 720.170µs 723.472µs 0.72% 1.935 9.857 0.10% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [718.332µs; 718.536µs] or [-0.014%; +0.014%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2598 execution_time 3.399ms 3.433ms ± 0.020ms 3.429ms ± 0.008ms 3.436ms 3.471ms 3.500ms 3.535ms 3.10% 2.120 5.973 0.58% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2598 execution_time [3.430ms; 3.435ms] or [-0.081%; +0.081%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.234ms 4.240ms ± 0.008ms 4.239ms ± 0.002ms 4.241ms 4.245ms 4.247ms 4.343ms 2.45% 11.482 148.131 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.239ms; 4.241ms] or [-0.026%; +0.026%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 188.433ns 190.926ns ± 2.172ns 190.784ns ± 1.632ns 191.835ns 195.170ns 197.532ns 198.613ns 4.10% 1.147 1.241 1.13% 0.154ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.625ns; 191.227ns] or [-0.158%; +0.158%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.244µs 185.772µs ± 0.248µs 185.726µs ± 0.182µs 185.975µs 186.197µs 186.326µs 186.420µs 0.37% 0.354 -0.753 0.13% 0.018µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5364237.061op/s 5382953.669op/s ± 7179.574op/s 5384269.238op/s ± 5270.527op/s 5388738.184op/s 5392969.873op/s 5395699.789op/s 5398276.762op/s 0.26% -0.350 -0.757 0.13% 507.673op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.885µs 18.002µs ± 0.102µs 17.992µs ± 0.025µs 18.018µs 18.075µs 18.129µs 19.289µs 7.21% 10.214 126.385 0.56% 0.007µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 51843967.954op/s 55549867.217op/s ± 297074.457op/s 55579790.636op/s ± 77393.422op/s 55649376.240op/s 55768732.997op/s 55899759.499op/s 55912907.424op/s 0.60% -9.807 119.531 0.53% 21006.336op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.315µs 10.396µs ± 0.047µs 10.385µs ± 0.028µs 10.426µs 10.495µs 10.528µs 10.576µs 1.84% 0.929 0.714 0.45% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 94550455.561op/s 96192445.184op/s ± 435954.978op/s 96291957.257op/s ± 263888.655op/s 96526543.528op/s 96743294.563op/s 96826363.516op/s 96944842.057op/s 0.68% -0.904 0.641 0.45% 30826.672op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.738µs; 185.806µs] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5381958.649op/s; 5383948.689op/s] or [-0.018%; +0.018%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.988µs; 18.016µs] or [-0.078%; +0.078%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55508695.554op/s; 55591038.879op/s] or [-0.074%; +0.074%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.389µs; 10.403µs] or [-0.063%; +0.063%] None None None
normalization/normalize_name/normalize_name/good throughput [96132026.017op/s; 96252864.351op/s] or [-0.063%; +0.063%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.190µs 3.223µs ± 1.437µs 2.997µs ± 0.028µs 3.023µs 3.689µs 14.183µs 14.756µs 392.44% 7.271 54.305 44.48% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.024µs; 3.422µs] or [-6.180%; +6.180%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.436µs 2.495µs ± 0.018µs 2.496µs ± 0.010µs 2.506µs 2.522µs 2.530µs 2.532µs 1.46% -0.787 1.045 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.492µs; 2.497µs] or [-0.101%; +0.101%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.383µs 33.629µs ± 1.784µs 32.496µs ± 0.055µs 36.052µs 36.707µs 36.760µs 36.985µs 13.81% 0.932 -1.078 5.29% 0.126µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.382µs; 33.877µs] or [-0.735%; +0.735%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.655ms 10.690ms ± 0.014ms 10.688ms ± 0.008ms 10.698ms 10.717ms 10.724ms 10.757ms 0.65% 0.935 2.061 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.688ms; 10.692ms] or [-0.019%; +0.019%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.917µs 3.918µs 3.920µs 0.19% -1.323 11.805 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255131221.893op/s 255609835.607op/s ± 173403.750op/s 255621842.887op/s ± 102912.435op/s 255717956.302op/s 255816305.479op/s 255897084.746op/s 256848592.377op/s 0.48% 1.347 11.993 0.07% 12261.497op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.114µs 79.777µs ± 0.404µs 79.717µs ± 0.240µs 79.965µs 80.452µs 81.196µs 81.343µs 2.04% 1.166 2.057 0.50% 0.029µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12293655.625op/s 12535279.739op/s ± 63096.027op/s 12544395.713op/s ± 37773.885op/s 12580747.997op/s 12618436.166op/s 12633079.124op/s 12639949.825op/s 0.76% -1.125 1.910 0.50% 4461.563op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.454µs 73.018µs ± 0.329µs 72.962µs ± 0.224µs 73.225µs 73.605µs 73.854µs 73.960µs 1.37% 0.486 -0.381 0.45% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13520912.806op/s 13695482.463op/s ± 61527.080op/s 13705672.778op/s ± 41932.242op/s 13742555.541op/s 13782201.113op/s 13792933.964op/s 13801809.044op/s 0.70% -0.467 -0.409 0.45% 4350.622op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.913µs ± 0.003µs 3.912µs ± 0.002µs 3.915µs 3.919µs 3.921µs 3.921µs 0.24% -0.362 5.056 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255015300.918op/s 255574896.070op/s ± 210628.393op/s 255620743.623op/s ± 105421.390op/s 255693411.195op/s 255825764.963op/s 255904988.077op/s 256810527.785op/s 0.47% 0.379 5.148 0.08% 14893.676op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.212µs 69.696µs ± 0.323µs 69.621µs ± 0.216µs 69.891µs 70.267µs 70.615µs 70.783µs 1.67% 0.953 0.629 0.46% 0.023µs 1 200
credit_card/is_card_number/378282246310005 throughput 14127631.970op/s 14348316.337op/s ± 66242.589op/s 14363566.815op/s ± 44588.278op/s 14401907.199op/s 14428490.648op/s 14442962.225op/s 14448387.650op/s 0.59% -0.929 0.561 0.46% 4684.058op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.150µs 52.223µs ± 0.035µs 52.218µs ± 0.022µs 52.243µs 52.284µs 52.317µs 52.352µs 0.26% 0.743 0.806 0.07% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19101440.388op/s 19148525.708op/s ± 12977.210op/s 19150651.649op/s ± 7957.135op/s 19157108.193op/s 19165241.823op/s 19173321.225op/s 19175459.247op/s 0.13% -0.738 0.795 0.07% 917.627op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.041µs ± 0.013µs 6.038µs ± 0.003µs 6.041µs 6.076µs 6.081µs 6.116µs 1.28% 3.438 13.487 0.21% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163507753.445op/s 165539189.432op/s ± 341510.328op/s 165606887.529op/s ± 86509.590op/s 165695207.304op/s 165784865.274op/s 165853345.875op/s 165928749.374op/s 0.19% -3.416 13.290 0.21% 24148.427op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.898µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.920µs 3.921µs 0.22% -0.349 2.806 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255014461.295op/s 255555143.487op/s ± 189443.241op/s 255566009.728op/s ± 117902.996op/s 255676370.532op/s 255815984.162op/s 255899860.389op/s 256542151.050op/s 0.38% 0.360 2.849 0.07% 13395.660op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.120µs 64.446µs ± 0.152µs 64.426µs ± 0.104µs 64.542µs 64.698µs 64.850µs 65.002µs 0.89% 0.625 0.546 0.23% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15384098.030op/s 15516915.904op/s ± 36446.645op/s 15521652.133op/s ± 25100.124op/s 15543092.080op/s 15566591.526op/s 15588558.410op/s 15595756.395op/s 0.48% -0.610 0.512 0.23% 2577.167op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.133µs 58.380µs ± 0.162µs 58.342µs ± 0.089µs 58.451µs 58.765µs 58.841µs 58.894µs 0.95% 1.096 0.935 0.28% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16979681.836op/s 17129179.914op/s ± 47467.554op/s 17140319.977op/s ± 26042.823op/s 17162227.226op/s 17189182.762op/s 17197353.757op/s 17201919.734op/s 0.36% -1.082 0.897 0.28% 3356.463op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.893µs 3.913µs ± 0.004µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.920µs 3.948µs 0.91% 4.296 36.272 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 253297728.232op/s 255568380.924op/s ± 287299.614op/s 255606766.950op/s ± 97579.178op/s 255698326.014op/s 255801806.488op/s 255872950.954op/s 256892201.597op/s 0.50% -4.229 35.805 0.11% 20315.151op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.591µs 54.981µs ± 0.277µs 54.941µs ± 0.176µs 55.103µs 55.582µs 55.752µs 55.951µs 1.84% 1.045 0.973 0.50% 0.020µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17872778.031op/s 18188443.543op/s ± 91140.185op/s 18201214.138op/s ± 58348.757op/s 18261368.717op/s 18295748.789op/s 18310918.750op/s 18318100.457op/s 0.64% -1.017 0.890 0.50% 6444.584op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.159µs 52.228µs ± 0.037µs 52.225µs ± 0.025µs 52.250µs 52.297µs 52.329µs 52.354µs 0.25% 0.660 0.179 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19100590.974op/s 19146684.070op/s ± 13714.690op/s 19148029.378op/s ± 9206.347op/s 19157166.492op/s 19165542.750op/s 19169470.628op/s 19172263.486op/s 0.13% -0.656 0.170 0.07% 969.775op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.029µs 6.044µs ± 0.018µs 6.038µs ± 0.004µs 6.044µs 6.078µs 6.116µs 6.148µs 1.82% 3.029 11.183 0.30% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 162651292.729op/s 165450975.247op/s ± 496656.815op/s 165614605.308op/s ± 110450.721op/s 165707386.940op/s 165821020.375op/s 165868720.527op/s 165876323.615op/s 0.16% -2.994 10.891 0.30% 35118.940op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255585803.514op/s; 255633867.699op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.721µs; 79.833µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12526535.237op/s; 12544024.242op/s] or [-0.070%; +0.070%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [72.973µs; 73.064µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13686955.401op/s; 13704009.524op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631 throughput [255545705.000op/s; 255604087.139op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.651µs; 69.741µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/378282246310005 throughput [14339135.751op/s; 14357496.923op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.218µs; 52.228µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19146727.191op/s; 19150324.224op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.039µs; 6.043µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number/x371413321323331 throughput [165491859.385op/s; 165586519.479op/s] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255528888.476op/s; 255581398.498op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.425µs; 64.467µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15511864.750op/s; 15521967.059op/s] or [-0.033%; +0.033%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.358µs; 58.403µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17122601.367op/s; 17135758.460op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255528563.961op/s; 255608197.888op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.943µs; 55.020µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18175812.390op/s; 18201074.696op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.223µs; 52.234µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19144783.346op/s; 19148584.794op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.042µs; 6.047µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165382143.389op/s; 165519807.105op/s] or [-0.042%; +0.042%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.036µs 86.401µs ± 0.164µs 86.382µs ± 0.050µs 86.434µs 86.555µs 86.811µs 88.235µs 2.15% 7.265 76.683 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.379µs; 86.424µs] or [-0.026%; +0.026%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.964µs 5.069µs ± 0.053µs 5.052µs ± 0.036µs 5.099µs 5.157µs 5.167µs 5.174µs 2.41% 0.187 -0.834 1.04% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.061µs; 5.076µs] or [-0.144%; +0.144%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 240.354ns 251.278ns ± 15.207ns 244.159ns ± 2.206ns 252.243ns 283.860ns 301.451ns 312.022ns 27.79% 1.908 2.833 6.04% 1.075ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [249.171ns; 253.386ns] or [-0.839%; +0.839%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.020µs 161.854µs ± 0.464µs 161.753µs ± 0.176µs 161.987µs 162.633µs 163.223µs 165.269µs 2.17% 3.279 18.403 0.29% 0.033µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.790µs; 161.919µs] or [-0.040%; +0.040%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.007µs 534.940µs ± 0.985µs 534.750µs ± 0.309µs 535.113µs 536.258µs 537.440µs 545.237µs 1.96% 6.373 59.312 0.18% 0.070µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1834065.611op/s 1869374.966op/s ± 3402.393op/s 1870031.286op/s ± 1081.290op/s 1870995.262op/s 1872026.506op/s 1872458.069op/s 1872635.866op/s 0.14% -6.261 57.617 0.18% 240.586op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.607µs 381.640µs ± 0.320µs 381.631µs ± 0.209µs 381.837µs 382.201µs 382.401µs 382.797µs 0.31% 0.223 0.834 0.08% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2612348.595op/s 2620271.879op/s ± 2197.632op/s 2620334.445op/s ± 1435.173op/s 2621774.067op/s 2623525.684op/s 2625021.213op/s 2627384.151op/s 0.27% -0.216 0.832 0.08% 155.396op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.839µs 190.182µs ± 0.171µs 190.181µs ± 0.117µs 190.288µs 190.458µs 190.607µs 190.742µs 0.30% 0.307 -0.031 0.09% 0.012µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5242678.901op/s 5258131.766op/s ± 4714.471op/s 5258146.689op/s ± 3236.820op/s 5261601.426op/s 5265980.951op/s 5267101.312op/s 5267623.645op/s 0.18% -0.302 -0.038 0.09% 333.363op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.500µs 37.616µs ± 0.053µs 37.613µs ± 0.036µs 37.648µs 37.706µs 37.742µs 37.759µs 0.39% 0.242 -0.345 0.14% 0.004µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26483447.451op/s 26584377.203op/s ± 37792.153op/s 26586579.870op/s ± 25570.453op/s 26614286.167op/s 26645137.630op/s 26654279.747op/s 26666586.244op/s 0.30% -0.235 -0.351 0.14% 2672.309op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.775µs 45.932µs ± 0.184µs 45.914µs ± 0.049µs 45.961µs 46.041µs 46.151µs 48.001µs 4.55% 8.564 86.870 0.40% 0.013µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20832696.163op/s 21771584.234op/s ± 84523.232op/s 21779783.682op/s ± 23014.534op/s 21803168.419op/s 21826993.236op/s 21843722.157op/s 21845869.028op/s 0.30% -8.379 83.927 0.39% 5976.695op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.803µs; 535.076µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1868903.427op/s; 1869846.505op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.596µs; 381.684µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2619967.308op/s; 2620576.450op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.158µs; 190.205µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5257478.386op/s; 5258785.146op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.609µs; 37.624µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26579139.574op/s; 26589614.832op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.907µs; 45.958µs] or [-0.056%; +0.056%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21759870.127op/s; 21783298.341op/s] or [-0.054%; +0.054%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.135ms 48.455ms ± 0.855ms 48.372ms ± 0.081ms 48.441ms 48.590ms 51.479ms 59.198ms 22.38% 10.639 125.392 1.76% 0.060ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.337ms; 48.574ms] or [-0.245%; +0.245%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 1094da4 1773077019 gyuheon0h/subprocess-thread-count
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.157µs 26.051µs ± 9.054µs 18.818µs ± 0.553µs 33.958µs 42.797µs 43.522µs 58.915µs 213.08% 0.740 -0.420 34.67% 0.640µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.796µs; 27.306µs] or [-4.817%; +4.817%] None None None

Baseline

Omitted due to size.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026 •
edited
Loading

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/gyuheon0h/subprocess-thread-count

Summary by Rule

Rule Base Branch PR Branch Change

Annotation Counts by File

File Base Branch PR Branch Change

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 28 28 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 208 208 No change (0%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Mar 9, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 100.28 MB 100.28 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.63 MB 8.63 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 116.94 MB 116.94 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.21 MB 11.21 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.16 MB 27.16 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.05 MB 186.01 MB --.01% (-32.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.14 MB 917.14 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.77 MB 24.77 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.43 MB 51.43 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.26 MB 190.23 MB --.01% (-32.00 KB) 💪
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.80 MB 900.80 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.51 MB 26.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.05 MB 47.05 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 87.50 MB 87.50 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.21 MB 10.21 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 109.81 MB 109.81 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.95 MB 11.95 MB 0% (0 B) 👌

@yannham
Copy link
Contributor

yannham commented Mar 9, 2026

Just in case, #1675 might be an alternative solution I think

@gyuheon0h
Copy link
Contributor Author

gyuheon0h commented Mar 9, 2026 •
edited
Loading

Just in case, #1675 might be an alternative solution I think
@yannham

Hmm not sure that will fix the issue; I think the issue is because the the logic of the test counts threads that aren't from the test itself. Maybe this will fix?

@gyuheon0h
Copy link
Contributor Author

gyuheon0h commented Mar 9, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 9, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-09 17:59:40 UTC ℹ️ Start processing command /merge

2026-03-09 17:59:45 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 45m (p90).

2026-03-09 18:39:45 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 3f3efef into main Mar 9, 2026
76 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the gyuheon0h/subprocess-thread-count branch March 9, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielsn danielsn danielsn approved these changes

Assignees

No one assigned

Labels

common mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gyuheon0h @codecov-commenter @yannham @danielsn