Remove obsolete ref_protected from STS trust policies#1655
Open
Remove obsolete ref_protected from STS trust policies#1655
ref_protected from STS trust policies#1655Conversation
The `ref_protected` OIDC claim is now universally `true` in the DataDog org due to the org-level "incompatible file paths on windows" push ruleset, making it useless as a security discriminator. Ticket: https://datadoghq.atlassian.net/browse/SINT-4732 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
+ Coverage 71.20% 71.23% +0.02%
==========================================
Files 425 425
Lines 62715 62715
==========================================
+ Hits 44657 44672 +15
+ Misses 18058 18043 -15
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-03-04 22:53:06 Comparing candidate commit cc0b6bc in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ref_protected: "true"from dd-octo-sts trust policy claim patternsThe
ref_protectedOIDC claim is now obsolete in the DataDog org:ref_protected: truein OIDC tokens, making it useless as a security signalgitlab.ddbuild.ioreportref_protected: truedue to org-levelpushAccessLevels: 40configSince the claim is universally
true, it provides no actual filtering — only a false sense of security. Removing it has zero functional impact on policy enforcement.All other constraints (subject, ref, job_workflow_ref, project_path, pipeline_source, etc.) remain unchanged and continue to provide the real security boundaries.
Ticket: https://datadoghq.atlassian.net/browse/SINT-4732
Test plan
🤖 Generated with Claude Code