Skip to content

feat(rc)!: add process_tags to remote config Target#1586

Open
dubloom wants to merge 3 commits intomainfrom
dubloom/process-tags-rc
Open

feat(rc)!: add process_tags to remote config Target#1586
dubloom wants to merge 3 commits intomainfrom
dubloom/process-tags-rc

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Feb 17, 2026

What does this PR do?

This PR allows to send process_tags through Remote Configuration payload. This PR comes with DataDog/dd-trace-php#3658 testing the feature in PHP Tracer.

Motivation

Process tags must be sent by dd-trace-php for every product including RC. PHP tracer is using libdatadog for sending RC payload.

How to test the change?

The changes is mainly validated in dd-trace-php. I also added a test here and modified the one impacted by the add of process_tags in the .proto.

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

📚 Documentation Check Results

⚠️ 111 documentation warning(s) found

📦 libdd-trace-protobuf - 111 warning(s)


Updated: 2026-03-10 15:15:37 UTC | Commit: fb11aad | missing-docs job results

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

Clippy Allow Annotation Report

Comparing clippy allow annotations between branches:

  • Base Branch: origin/main
  • PR Branch: origin/dubloom/process-tags-rc

Summary by Rule

Rule Base Branch PR Branch Change
expect_used 2 2 No change (0%)
unwrap_used 8 8 No change (0%)
Total 10 10 No change (0%)

Annotation Counts by File

File Base Branch PR Branch Change
datadog-remote-config/src/fetch/fetcher.rs 2 2 No change (0%)
datadog-sidecar/src/service/runtime_info.rs 1 1 No change (0%)
datadog-sidecar/src/shm_remote_config.rs 7 7 No change (0%)

Annotation Stats by Crate

Crate Base Branch PR Branch Change
clippy-annotation-reporter 5 5 No change (0%)
datadog-ffe-ffi 1 1 No change (0%)
datadog-ipc 28 28 No change (0%)
datadog-live-debugger 6 6 No change (0%)
datadog-live-debugger-ffi 10 10 No change (0%)
datadog-profiling-replayer 4 4 No change (0%)
datadog-remote-config 3 3 No change (0%)
datadog-sidecar 59 59 No change (0%)
libdd-common 10 10 No change (0%)
libdd-common-ffi 12 12 No change (0%)
libdd-crashtracker 0 12 ⚠️ +12 (N/A)
libdd-data-pipeline 5 5 No change (0%)
libdd-ddsketch 2 2 No change (0%)
libdd-dogstatsd-client 1 1 No change (0%)
libdd-profiling 13 13 No change (0%)
libdd-telemetry 19 19 No change (0%)
libdd-tinybytes 4 4 No change (0%)
libdd-trace-normalization 2 2 No change (0%)
libdd-trace-obfuscation 9 9 No change (0%)
libdd-trace-utils 15 15 No change (0%)
Total 208 220 ⚠️ +12 (+5.8%)

About This Report

This report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality.

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

🔒 Cargo Deny Results

No issues found!

📦 libdd-trace-protobuf - ✅ No issues


Updated: 2026-03-10 15:18:59 UTC | Commit: fb11aad | dependency-check job results

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Benchmarks

Comparison

Benchmark execution time: 2026-03-10 15:28:26

Comparing candidate commit 7736bc9 in PR branch dubloom/process-tags-rc with baseline commit 3f3efef in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:ip_address/quantize_peer_ip_address_benchmark

  • 🟩 execution_time [-354.687ns; -328.491ns] or [-6.632%; -6.142%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 4.194ms 4.199ms ± 0.008ms 4.198ms ± 0.001ms 4.200ms 4.202ms 4.206ms 4.305ms 2.55% 12.212 161.076 0.19% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [4.198ms; 4.200ms] or [-0.026%; +0.026%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 3.272ms 3.297ms ± 0.021ms 3.291ms ± 0.009ms 3.302ms 3.338ms 3.365ms 3.404ms 3.44% 1.923 4.632 0.64% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [3.294ms; 3.300ms] or [-0.089%; +0.089%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.667ms 10.695ms ± 0.014ms 10.693ms ± 0.007ms 10.702ms 10.722ms 10.731ms 10.771ms 0.73% 1.308 4.465 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.693ms; 10.697ms] or [-0.018%; +0.018%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.726ms 49.051ms ± 1.128ms 48.850ms ± 0.079ms 49.022ms 49.246ms 55.378ms 61.576ms 26.05% 8.814 84.748 2.29% 0.080ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.895ms; 49.208ms] or [-0.319%; +0.319%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.547µs 33.318µs ± 1.004µs 32.699µs ± 0.050µs 34.621µs 35.100µs 35.510µs 36.032µs 10.19% 1.016 -0.711 3.01% 0.071µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.179µs; 33.457µs] or [-0.418%; +0.418%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.938µs 5.007µs ± 0.056µs 4.995µs ± 0.037µs 5.035µs 5.110µs 5.112µs 5.115µs 2.41% 0.606 -0.966 1.13% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.999µs; 5.015µs] or [-0.156%; +0.156%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.845µs 25.022µs ± 9.149µs 18.123µs ± 0.170µs 33.589µs 42.199µs 44.371µs 65.314µs 260.39% 1.048 0.649 36.47% 0.647µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.754µs; 26.290µs] or [-5.067%; +5.067%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.453µs 146.379µs ± 1.699µs 146.081µs ± 0.597µs 146.722µs 148.476µs 152.360µs 162.423µs 11.19% 5.289 41.628 1.16% 0.120µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.143µs; 146.614µs] or [-0.161%; +0.161%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 239.416ns 251.506ns ± 12.757ns 245.483ns ± 3.906ns 255.868ns 281.275ns 284.728ns 285.516ns 16.31% 1.357 0.598 5.06% 0.902ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [249.738ns; 253.274ns] or [-0.703%; +0.703%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.424µs 2.459µs ± 0.014µs 2.458µs ± 0.011µs 2.471µs 2.478µs 2.481µs 2.483µs 1.03% -0.515 -0.216 0.56% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.457µs; 2.461µs] or [-0.078%; +0.078%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.923ms 13.982ms ± 0.037ms 13.973ms ± 0.015ms 13.993ms 14.046ms 14.122ms 14.193ms 1.57% 2.496 9.428 0.26% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.977ms; 13.987ms] or [-0.036%; +0.036%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 187.919ns 190.560ns ± 2.145ns 190.430ns ± 1.603ns 191.784ns 194.310ns 197.100ns 199.473ns 4.75% 0.998 1.465 1.12% 0.152ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.263ns; 190.858ns] or [-0.156%; +0.156%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 724.080µs 725.672µs ± 0.760µs 725.536µs ± 0.417µs 726.023µs 727.225µs 728.000µs 729.072µs 0.49% 1.221 2.479 0.10% 0.054µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [725.567µs; 725.778µs] or [-0.015%; +0.015%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 85.690µs 86.053µs ± 0.198µs 86.037µs ± 0.080µs 86.126µs 86.229µs 86.388µs 87.988µs 2.27% 5.613 49.064 0.23% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.025µs; 86.080µs] or [-0.032%; +0.032%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.892µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.916µs 3.918µs 3.925µs 0.35% -0.952 15.083 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254748768.100op/s 255632138.790op/s ± 180740.403op/s 255631477.983op/s ± 80182.469op/s 255714064.276op/s 255874318.218op/s 255963103.285op/s 256933718.637op/s 0.51% 0.987 15.256 0.07% 12780.276op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 79.031µs 79.775µs ± 0.381µs 79.728µs ± 0.249µs 80.019µs 80.514µs 80.759µs 80.906µs 1.48% 0.568 0.101 0.48% 0.027µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12359974.244op/s 12535526.434op/s ± 59650.352op/s 12542580.706op/s ± 39299.501op/s 12579050.556op/s 12627531.997op/s 12641814.841op/s 12653224.524op/s 0.88% -0.543 0.062 0.47% 4217.917op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 72.408µs 73.074µs ± 0.341µs 73.043µs ± 0.230µs 73.305µs 73.676µs 73.851µs 74.323µs 1.75% 0.572 0.431 0.46% 0.024µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13454734.034op/s 13685030.007op/s ± 63628.685op/s 13690490.452op/s ± 43089.908op/s 13732041.500op/s 13783307.255op/s 13798956.746op/s 13810587.196op/s 0.88% -0.543 0.363 0.46% 4499.227op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.913µs ± 0.003µs 3.912µs ± 0.002µs 3.915µs 3.919µs 3.921µs 3.924µs 0.29% -0.490 6.072 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254859175.349op/s 255554219.836op/s ± 222755.534op/s 255594172.453op/s ± 135290.589op/s 255689043.711op/s 255808911.470op/s 255907124.896op/s 256911507.555op/s 0.52% 0.510 6.187 0.09% 15751.195op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 69.204µs 69.747µs ± 0.321µs 69.733µs ± 0.229µs 69.939µs 70.292µs 70.592µs 71.022µs 1.85% 0.822 0.858 0.46% 0.023µs 1 200
credit_card/is_card_number/378282246310005 throughput 14080142.804op/s 14337890.078op/s ± 65664.861op/s 14340469.847op/s ± 47026.924op/s 14390551.166op/s 14422754.853op/s 14435321.069op/s 14450050.640op/s 0.76% -0.792 0.762 0.46% 4643.207op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.139µs 52.203µs ± 0.031µs 52.199µs ± 0.020µs 52.222µs 52.252µs 52.280µs 52.359µs 0.31% 0.949 2.670 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19098970.267op/s 19156026.583op/s ± 11229.954op/s 19157283.090op/s ± 7467.185op/s 19163820.623op/s 19171590.389op/s 19176454.365op/s 19179671.466op/s 0.12% -0.943 2.639 0.06% 794.078op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.026µs 6.035µs ± 0.007µs 6.034µs ± 0.002µs 6.036µs 6.042µs 6.070µs 6.080µs 0.76% 4.325 22.405 0.11% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 164480071.640op/s 165692236.983op/s ± 181963.858op/s 165723049.365op/s ± 46528.045op/s 165768748.442op/s 165846804.096op/s 165878848.496op/s 165956757.241op/s 0.14% -4.306 22.255 0.11% 12866.788op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.919µs 3.921µs 3.922µs 0.25% -0.441 7.647 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254987641.027op/s 255610424.574op/s ± 201643.990op/s 255616362.329op/s ± 96910.917op/s 255725054.662op/s 255855292.651op/s 255908804.187op/s 256882068.527op/s 0.50% 0.464 7.770 0.08% 14258.383op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.098µs 64.353µs ± 0.140µs 64.334µs ± 0.083µs 64.417µs 64.627µs 64.762µs 64.872µs 0.84% 0.945 0.860 0.22% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15414907.045op/s 15539258.086op/s ± 33648.926op/s 15543966.333op/s ± 19992.313op/s 15563600.241op/s 15581555.958op/s 15595328.253op/s 15601062.432op/s 0.37% -0.932 0.824 0.22% 2379.338op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.095µs 58.370µs ± 0.154µs 58.337µs ± 0.083µs 58.432µs 58.651µs 58.870µs 58.944µs 1.04% 1.214 1.795 0.26% 0.011µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16965344.998op/s 17132322.349op/s ± 44925.309op/s 17141768.621op/s ± 24490.769op/s 17164906.613op/s 17186304.433op/s 17202317.174op/s 17213303.476op/s 0.42% -1.196 1.736 0.26% 3176.699op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.892µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.913µs 3.915µs 3.917µs 3.918µs 0.16% -2.123 17.338 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255249076.981op/s 255662913.706op/s ± 163141.417op/s 255657254.108op/s ± 88915.742op/s 255758504.772op/s 255874278.534op/s 255927944.527op/s 256942703.385op/s 0.50% 2.151 17.597 0.06% 11535.840op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.555µs 54.955µs ± 0.293µs 54.880µs ± 0.169µs 55.103µs 55.527µs 55.807µs 56.030µs 2.10% 1.152 1.085 0.53% 0.021µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17847428.478op/s 18197259.036op/s ± 96381.196op/s 18221546.294op/s ± 56246.274op/s 18271767.840op/s 18305688.679op/s 18316014.574op/s 18330276.117op/s 0.60% -1.124 0.987 0.53% 6815.180op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.144µs 52.213µs ± 0.036µs 52.208µs ± 0.020µs 52.230µs 52.283µs 52.320µs 52.341µs 0.25% 0.863 1.265 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19105504.176op/s 19152176.465op/s ± 13111.173op/s 19154089.563op/s ± 7473.241op/s 19160748.731op/s 19170434.685op/s 19177176.437op/s 19177566.083op/s 0.12% -0.857 1.253 0.07% 927.100op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.039µs ± 0.013µs 6.036µs ± 0.004µs 6.040µs 6.070µs 6.080µs 6.121µs 1.41% 2.866 10.631 0.21% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163379343.467op/s 165578807.976op/s ± 341035.324op/s 165679687.680op/s ± 96117.759op/s 165756697.081op/s 165868146.345op/s 165895707.998op/s 165928466.906op/s 0.15% -2.839 10.388 0.21% 24114.839op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [255607089.908op/s; 255657187.671op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [79.722µs; 79.828µs] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12527259.469op/s; 12543793.399op/s] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [73.027µs; 73.121µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13676211.683op/s; 13693848.331op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255523348.061op/s; 255585091.611op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [69.702µs; 69.791µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number/378282246310005 throughput [14328789.559op/s; 14346990.596op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.199µs; 52.207µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19154470.219op/s; 19157582.947op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.034µs; 6.036µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/x371413321323331 throughput [165667018.542op/s; 165717455.423op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255582478.656op/s; 255638370.491op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.334µs; 64.373µs] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15534594.669op/s; 15543921.504op/s] or [-0.030%; +0.030%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.348µs; 58.391µs] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17126096.133op/s; 17138548.564op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255640303.875op/s; 255685523.537op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.914µs; 54.995µs] or [-0.074%; +0.074%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18183901.529op/s; 18210616.543op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.208µs; 52.218µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19150359.382op/s; 19153993.547op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.038µs; 6.041µs] or [-0.029%; +0.029%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165531543.760op/s; 165626072.192op/s] or [-0.029%; +0.029%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.194µs 3.189µs ± 1.427µs 2.986µs ± 0.029µs 3.012µs 3.643µs 13.836µs 14.801µs 395.74% 7.384 55.573 44.64% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.991µs; 3.387µs] or [-6.202%; +6.202%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 185.323µs 185.931µs ± 0.329µs 185.872µs ± 0.224µs 186.140µs 186.578µs 186.779µs 186.892µs 0.55% 0.703 -0.010 0.18% 0.023µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5350681.670op/s 5378363.379op/s ± 9493.490op/s 5380051.189op/s ± 6486.695op/s 5385620.709op/s 5390828.314op/s 5393166.237op/s 5395993.771op/s 0.30% -0.695 -0.025 0.18% 671.291op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.849µs 17.962µs ± 0.064µs 17.958µs ± 0.043µs 18.001µs 18.067µs 18.109µs 18.228µs 1.50% 0.576 0.590 0.36% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 54861564.449op/s 55673915.723op/s ± 197814.166op/s 55684797.840op/s ± 133762.094op/s 55818524.131op/s 55968073.629op/s 56009203.445op/s 56024914.609op/s 0.61% -0.552 0.518 0.35% 13987.574op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.241µs 10.428µs ± 0.080µs 10.430µs ± 0.066µs 10.485µs 10.559µs 10.617µs 10.660µs 2.20% 0.232 -0.485 0.77% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 93810030.424op/s 95897939.994op/s ± 738091.072op/s 95874422.667op/s ± 608248.887op/s 96550637.460op/s 96992162.813op/s 97234193.180op/s 97648014.416op/s 1.85% -0.199 -0.516 0.77% 52190.920op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [185.885µs; 185.976µs] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5377047.673op/s; 5379679.086op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.953µs; 17.971µs] or [-0.049%; +0.049%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [55646500.582op/s; 55701330.863op/s] or [-0.049%; +0.049%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.417µs; 10.440µs] or [-0.107%; +0.107%] None None None
normalization/normalize_name/normalize_name/good throughput [95795647.670op/s; 96000232.318op/s] or [-0.107%; +0.107%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.447µs 535.690µs ± 1.633µs 535.150µs ± 0.375µs 535.823µs 537.781µs 543.373µs 547.376µs 2.28% 4.088 22.303 0.30% 0.115µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1826899.352op/s 1866768.978op/s ± 5622.757op/s 1868636.092op/s ± 1309.109op/s 1869761.232op/s 1870528.179op/s 1870891.936op/s 1871093.542op/s 0.13% -4.020 21.636 0.30% 397.589op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.540µs 381.341µs ± 0.309µs 381.343µs ± 0.210µs 381.559µs 381.811µs 382.054µs 382.475µs 0.30% 0.254 0.519 0.08% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2614553.240op/s 2622329.429op/s ± 2123.855op/s 2622310.699op/s ± 1443.816op/s 2623711.640op/s 2625624.938op/s 2627050.860op/s 2627841.639op/s 0.21% -0.248 0.511 0.08% 150.179op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.672µs 190.052µs ± 0.363µs 190.003µs ± 0.090µs 190.118µs 190.329µs 190.566µs 194.580µs 2.41% 9.814 119.065 0.19% 0.026µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5139268.239op/s 5261746.947op/s ± 9876.155op/s 5263080.476op/s ± 2507.691op/s 5265200.558op/s 5268740.840op/s 5269970.893op/s 5272250.927op/s 0.17% -9.673 116.672 0.19% 698.350op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.309µs 37.555µs ± 0.073µs 37.546µs ± 0.047µs 37.597µs 37.678µs 37.719µs 37.768µs 0.59% 0.241 0.159 0.19% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26477470.431op/s 26628047.071op/s ± 51632.009op/s 26634194.088op/s ± 33678.983op/s 26663154.960op/s 26706627.836op/s 26723368.310op/s 26803256.915op/s 0.63% -0.229 0.162 0.19% 3650.934op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.797µs 45.922µs ± 0.184µs 45.895µs ± 0.040µs 45.941µs 46.045µs 46.124µs 47.915µs 4.40% 8.565 82.871 0.40% 0.013µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20870397.614op/s 21776230.128op/s ± 84430.300op/s 21788747.205op/s ± 19040.889op/s 21806552.978op/s 21821279.391op/s 21831706.415op/s 21835263.611op/s 0.21% -8.428 80.775 0.39% 5970.124op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [535.463µs; 535.916µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1865989.718op/s; 1867548.238op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [381.298µs; 381.383µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2622035.083op/s; 2622623.775op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.001µs; 190.102µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5260378.207op/s; 5263115.687op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.544µs; 37.565µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26620891.372op/s; 26635202.771op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.897µs; 45.948µs] or [-0.056%; +0.056%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21764528.900op/s; 21787931.355op/s] or [-0.054%; +0.054%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7736bc9 1773155388 dubloom/process-tags-rc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.442µs 161.947µs ± 0.429µs 161.855µs ± 0.155µs 162.059µs 162.484µs 163.180µs 166.158µs 2.66% 5.338 45.933 0.26% 0.030µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.887µs; 162.006µs] or [-0.037%; +0.037%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 78.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.05%. Comparing base (04394ec) to head (7736bc9).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
- Coverage   71.33%   71.05%   -0.29%     
==========================================
  Files         427      427              
  Lines       62960    63035      +75     
==========================================
- Hits        44914    44788     -126     
- Misses      18046    18247     +201     
Components Coverage Δ
libdd-crashtracker 62.45% <ø> (-0.50%) ⬇️
libdd-crashtracker-ffi 17.49% <ø> (+0.92%) ⬆️
libdd-alloc 98.77% <ø> (ø)
libdd-data-pipeline 88.02% <ø> (ø)
libdd-data-pipeline-ffi 75.72% <ø> (ø)
libdd-common 79.73% <ø> (-0.01%) ⬇️
libdd-common-ffi 73.40% <ø> (ø)
libdd-telemetry 62.48% <ø> (ø)
libdd-telemetry-ffi 16.75% <ø> (ø)
libdd-dogstatsd-client 82.64% <ø> (ø)
datadog-ipc 80.35% <ø> (ø)
libdd-profiling 81.60% <ø> (+0.01%) ⬆️
libdd-profiling-ffi 63.65% <ø> (ø)
datadog-sidecar 32.44% <20.00%> (-2.05%) ⬇️
datdog-sidecar-ffi 7.73% <0.00%> (-8.82%) ⬇️
spawn-worker 54.69% <ø> (ø)
libdd-tinybytes 93.16% <ø> (ø)
libdd-trace-normalization 81.71% <ø> (ø)
libdd-trace-obfuscation 94.69% <ø> (ø)
libdd-trace-protobuf 68.25% <ø> (ø)
libdd-trace-utils 89.08% <ø> (ø)
datadog-tracer-flare 88.97% <100.00%> (+0.01%) ⬆️
libdd-log 74.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Feb 17, 2026

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.70 MB 8.70 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 98.65 MB 98.65 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.29 MB 11.29 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 114.30 MB 114.30 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 27.17 MB 27.17 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 186.03 MB 186.05 MB +0% (+16.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 917.20 MB 917.21 MB +0% (+7.04 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 9.93 MB 9.93 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 76.26 KB 76.26 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 24.76 MB 24.76 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 51.43 MB 51.43 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 22.97 MB 22.97 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 190.24 MB 190.25 MB +0% (+8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 900.85 MB 900.86 MB +0% (+6.42 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 7.53 MB 7.53 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 77.44 KB 77.44 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 26.52 MB 26.52 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 47.07 MB 47.07 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 86.54 MB 86.54 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 10.23 MB 10.23 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 107.16 MB 107.16 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.98 MB 11.98 MB 0% (0 B) 👌

@dubloom dubloom changed the title feat(rc): add process_tags to remote config Target feat!(rc): add process_tags to remote config Target Mar 5, 2026
@dubloom dubloom changed the title feat!(rc): add process_tags to remote config Target feat(rc)!: add process_tags to remote config Target Mar 5, 2026
@dubloom dubloom force-pushed the dubloom/process-tags-rc branch from 60b6c87 to ae9464f Compare March 9, 2026 12:50
@dubloom dubloom marked this pull request as ready for review March 10, 2026 10:34
@dubloom dubloom requested review from a team as code owners March 10, 2026 10:34
process_tags: vec![],
})
});
pub(crate) static DUMMY_TARGET_WITH_PROCESS_TAGS: LazyLock<Arc<Target>> = LazyLock::new(|| {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this create fork-safety issues?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be compiled only in test.
This is a duplicata of what the code is already doing with DUMMY_TARGET.

Happy to modify it if needed

app_version: "1.3.5".to_string(),
tags: vec![],
process_tags: vec![
libdd_common::tag::Tag::new("entrypoint.workdir", "datadog-remote-config").unwrap(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid using unwrap

pub env: String,
pub app_version: String,
pub tags: Vec<Tag>,
pub process_tags: Vec<Tag>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a separate thing rather than part of tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.expect("set_metadata was called before"),
self.global_tags.clone(),
dynamic_instrumentation_state,
process_tags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why can we clone the global tags but have to parse the process tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Process tags is used as a string for Telemetry. so the global process tags is a string but it should be sent as a Vec so we need to parse them.

If you feel this is required, we can parse them and store them when we receive new process_tags but it would mean we store kind of duplicate data

pub app_version: ::prost::alloc::string::String,
#[prost(string, repeated, tag = "7")]
pub tags: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
#[prost(string, repeated, tag = "9")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not for this PR, but why is this file checked in rather than auto-generated from the proto?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably me not familiar with proto

@dubloom dubloom requested a review from danielsn March 10, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants