Skip to content

Reapply #47007 with job-scoped repository caches#47328

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
regis.desgroppes/gitlab-bazel-cache-go
Mar 4, 2026
Merged

Reapply #47007 with job-scoped repository caches#47328
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
regis.desgroppes/gitlab-bazel-cache-go

Conversation

@rdesgroppes
Copy link
Contributor

@rdesgroppes rdesgroppes commented Mar 4, 2026

What does this PR do?

Reapply #47007, reverted in #47083 following #incident-50242, but with the following adjustments:

  1. scope repository caches to individual jobs ($CI_JOB_NAME) rather than runner types ($CI_RUNNER_DESCRIPTION),
  2. add .cache/ms-go* to the cached paths (neutral until msgo 1.26+).

Motivation

#incident-50242 traced to FIPS and non-FIPS omnibus jobs racing to write incompatible Go build artifacts to the same cache key: msgo tags indeed compile objects with X:systemcrypto while upstream Go does not.

It turns out to be a known issue: microsoft/go#1994.

Until the corresponding fix (microsoft/go#1998) is available, that is when bumping the Go SDK version to 1.26+, the main adjustment consists in temporarily scoping repository caches to jobs.
Per-job cache keys naturally segregate the two without requiring an explicit FIPS discriminator (we couldn't rely on $FLAVOR because it's not expanding consistently across jobs).

Additional Notes

When switching to Go SDK 1.26+, we'll revert $CI_RUNNER_DESCRIPTION because msgo 1.26+ will eliminate the conflict at the toolchain level thanks to microsoft/go#1998.

@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 4, 2026
@rdesgroppes rdesgroppes marked this pull request as ready for review March 4, 2026 16:24
@rdesgroppes rdesgroppes requested a review from a team as a code owner March 4, 2026 16:24
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 4, 2026
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 4, 2026

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 110 0 0

ℹ️ Diff available in the job log.

@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 4, 2026
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/gitlab-bazel-cache-go branch from 98e8b40 to 89e81ed Compare March 4, 2026 16:32
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Mar 4, 2026

Files inventory check summary

File checks results against ancestor 677d1b09:

Results for datadog-agent_7.78.0~devel.git.316.287a621.pipeline.100408114-1_amd64.deb:

No change detected

@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Mar 4, 2026
### What does this PR do?
Reapply #47007, reverted in #47083 following #incident-50242, but with
the following adjustments:
1. scope repository caches to individual jobs (`$CI_JOB_NAME`) rather
   than runner types (`$CI_RUNNER_DESCRIPTION`),
2. add `.cache/ms-go*` to the cached paths (neutral until `msgo` 1.26+).

### Motivation
#incident-50242 traced to FIPS and non-FIPS omnibus jobs racing to write
incompatible Go build artifacts to the same cache key: `msgo` tags
indeed compile objects with `X:systemcrypto` while upstream Go does not.

It turns out to be a **known issue**: microsoft/go#1994.

Until the corresponding fix is available (microsoft/go#1998), that is
when bumping the Go SDK version to 1.26+, the main adjustment consists
in temporarily scoping repository caches to jobs.
Per-job cache keys naturally segregate the two without requiring an
explicit FIPS discriminator (we couldn't rely on `$FLAVOR` because it's
not expanding consistently across jobs).

### Additional Notes
When switching to Go SDK 1.26+, we'll revert `$CI_RUNNER_DESCRIPTION`
because `msgo` 1.26+ will eliminate the conflict at the toolchain level
thanks to microsoft/go#1998.
@rdesgroppes rdesgroppes force-pushed the regis.desgroppes/gitlab-bazel-cache-go branch from 89e81ed to 287a621 Compare March 4, 2026 18:39
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 964a74e into main Mar 4, 2026
257 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the regis.desgroppes/gitlab-bazel-cache-go branch March 4, 2026 22:08
@github-actions github-actions bot added this to the 7.78.0 milestone Mar 4, 2026
@cit-pr-commenter-54b7da
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6232a7ef-817f-444d-ad3c-09f9205ef208

Baseline: 6fd665f
Comparison: 964a74e
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.74 [-0.37, +5.85] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +3.06 [+1.55, +4.56] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +2.74 [-0.37, +5.85] 1 Logs
quality_gate_metrics_logs memory utilization +1.11 [+0.89, +1.32] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.39 [+0.36, +0.43] 1 Logs bounds checks dashboard
ddot_logs memory utilization +0.38 [+0.31, +0.44] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization +0.34 [+0.12, +0.57] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.17 [+0.12, +0.22] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.35, +0.40] 1 Logs
quality_gate_idle memory utilization +0.01 [-0.03, +0.06] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api ingress throughput +0.01 [-0.12, +0.14] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.12, +0.12] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.00 [-0.08, +0.08] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.50, +0.49] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.03 [-0.44, +0.39] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.08, +0.01] 1 Logs
ddot_metrics_sum_delta memory utilization -0.05 [-0.21, +0.12] 1 Logs
file_tree memory utilization -0.15 [-0.20, -0.10] 1 Logs
otlp_ingest_metrics memory utilization -0.22 [-0.38, -0.06] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.37 [-0.51, -0.23] 1 Logs
ddot_metrics memory utilization -0.43 [-0.61, -0.24] 1 Logs
docker_containers_memory memory utilization -0.56 [-0.63, -0.49] 1 Logs
otlp_ingest_logs memory utilization -0.94 [-1.05, -0.83] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency lost_bytes 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 9/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants